From: Peter Jones <pjones@redhat.com>
To: Peter Jones <pjones@redhat.com>
Cc: James Bottomley <James.Bottomley@suse.de>,
Tejun Heo <tj@kernel.org>,
Linux SCSI <linux-scsi@vger.kernel.org>,
Chandra Seetharaman <sekharan@us.ibm.com>
Subject: Re: [PATCH 2/2] Use scsi_devinfo functions to do matching of scsi IDs device_handler tables.
Date: Thu, 06 Jan 2011 15:36:22 -0500 [thread overview]
Message-ID: <4D2627C6.2040200@redhat.com> (raw)
In-Reply-To: <1294345890-6089-2-git-send-email-pjones@redhat.com>
> int scsi_register_device_handler(struct scsi_device_handler *scsi_dh)
> {
> + int i;
> +
> if (get_device_handler(scsi_dh->name))
> return -EBUSY;
>
> spin_lock(&list_lock);
> + scsi_dh->idx = scsi_dh_list_idx++;
> list_add(&scsi_dh->list, &scsi_dh_list);
> spin_unlock(&list_lock);
> +
> + for (i = 0; scsi_dh->devlist[i].vendor; i++) {
> + scsi_dev_info_list_add_keyed(1, /* compatible */
This actually needs to be 0, or else this has the exact same bug I originally
set out to fix.
> + scsi_dh->devlist[i].vendor,
> + scsi_dh->devlist[i].model,
> + NULL,
> + scsi_dh->idx,
> + SCSI_DEVINFO_DH);
> + }
next prev parent reply other threads:[~2011-01-06 20:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 20:31 [PATCH 1/2] Add scsi_dev_info_list_del_keyed() Peter Jones
2011-01-06 20:31 ` [PATCH 2/2] Use scsi_devinfo functions to do matching of scsi IDs device_handler tables Peter Jones
2011-01-06 20:36 ` Peter Jones [this message]
2011-01-06 20:38 ` [PATCH] " Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2627C6.2040200@redhat.com \
--to=pjones@redhat.com \
--cc=James.Bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=sekharan@us.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.