From: Timur Tabi <timur@freescale.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: dp@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
lrg@slimlogic.co.uk
Subject: Re: [PATCH] ASoC: cs4270: fix dynamic initialization of register cache
Date: Thu, 6 Jan 2011 14:50:49 -0600 [thread overview]
Message-ID: <4D262B29.3010606@freescale.com> (raw)
In-Reply-To: <20110106201511.GA8018@opensource.wolfsonmicro.com>
Mark Brown wrote:
> Having a driver per device is pretty icky and off the top of my head I'd
> expect it to cause problems if there are two cs4270 in the system. It
> would be much nicer and more maintainable to avoid bodging around the
> API like this.
BTW, why does ASoC even care about the register cache, if I have to have my own
functions to read and write it? In other words, why does function
cs4270_read_reg_cache() exist at all? What is the point of having ASoC allocate
the cache if the driver has to supply functions to read and write it?
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-01-06 20:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 18:52 [PATCH] ASoC: cs4270: fix dynamic initialization of register cache Timur Tabi
2011-01-06 20:15 ` Mark Brown
2011-01-06 20:24 ` Timur Tabi
2011-01-06 21:41 ` Mark Brown
2011-01-06 20:50 ` Timur Tabi [this message]
2011-01-06 21:31 ` Mark Brown
2011-01-06 21:35 ` Timur Tabi
2011-01-06 22:04 ` Mark Brown
2011-01-06 22:07 ` Timur Tabi
2011-01-06 22:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D262B29.3010606@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.