From: Jeff Garzik <jgarzik@pobox.com>
To: maksim.rayskiy@gmail.com
Cc: linux-scsi@vger.kernel.org, tj@kernel.org
Subject: Re: [linux-pm] [RFC] Deferred disk spinup during system resume
Date: Thu, 06 Jan 2011 22:16:49 -0500 [thread overview]
Message-ID: <4D2685A1.6020708@pobox.com> (raw)
In-Reply-To: <1294363046-28820-1-git-send-email-maksim.rayskiy@gmail.com>
On 01/06/2011 08:17 PM, maksim.rayskiy@gmail.com wrote:
> Jeff,
>
> Okay, I moved EH scheduling to ata_qc_issue(). But since now START taskfile is
> created in ata_eh_maybe_verify() I do not see why the same code has to
> remain in ata_scsi_start_stop_xlat. Does it make sense?
The taskfile you are to pass to the hardware is created in
atapi_start_stop_xlat(), so you should not create a new taskfile in
ata_eh_maybe_verify()
Jeff
next prev parent reply other threads:[~2011-01-07 3:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 1:17 [linux-pm] [RFC] Deferred disk spinup during system resume maksim.rayskiy
2011-01-07 3:16 ` Jeff Garzik [this message]
2011-01-07 3:46 ` Maksim Rayskiy
-- strict thread matches above, loose matches on Subject: below --
2010-12-30 19:40 Maksim Rayskiy
2010-12-30 22:46 ` [linux-pm] " Rafael J. Wysocki
2010-12-31 0:49 ` Maksim Rayskiy
2010-12-31 11:27 ` Tejun Heo
2010-12-31 11:45 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2685A1.6020708@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=maksim.rayskiy@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.