All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Salih Gönüllü" <sag@open.ch>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter@vger.kernel.org
Subject: Re: ulogd2 segfault
Date: Fri, 07 Jan 2011 11:24:00 +0100	[thread overview]
Message-ID: <4D26E9C0.9090304@open.ch> (raw)
In-Reply-To: <4D25C945.7030502@netfilter.org>

On 01/06/2011 02:53 PM, Pablo Neira Ayuso wrote:

> Let me check this, if the problem is what you're pointing (which makes
> sense at first look at the code) I guess that we need some refcounting
> for plugins to avoid double freeing.


When I comment out nflog_unbind_group(ui->nful_gh) in  stop() inside 
input/packet/ulogd_inppkt_NFLOG.c,  ulogd does not segfault anymore.

Here I have question:

Does  *pi in
static int stop(struct ulogd_pluginstance *pi)

represent the NFLOG plugin or the individual log2:NFLOG ? I am asking 
because it get started only once with pluginstance_started(), and 
therefore should be stopped once (?)

Cheers,

-salih

  reply	other threads:[~2011-01-07 10:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-31 16:23 ulogd2 segfault Salih Gönüllü
2011-01-03 18:12 ` Salih Gönüllü
2011-01-06 13:53   ` Pablo Neira Ayuso
2011-01-07 10:24     ` Salih Gönüllü [this message]
2011-01-07 13:37       ` Pablo Neira Ayuso
2011-01-07 16:40         ` Salih Gönüllü
2011-01-08 14:36           ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D26E9C0.9090304@open.ch \
    --to=sag@open.ch \
    --cc=netfilter@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.