Re: [PATCH 4/4] gcc: replace unconditional SRC_URI_append with SRC_URI +=

[Andreas Oberritter <obi@opendreambox.org>]

On 01/07/2011 10:52 AM, Paul Menzel wrote:
> Am Donnerstag, den 06.01.2011, 12:48 +0000 schrieb Andreas Oberritter:
> 
> What do you mean by »unconditional SRC_URI_append«? I searched through
> the documentation and could not find the word.

Unconditional, because it doesn't contain an override like e.g.
SRC_URI_append_beagleboard does.

> I always thought
> `SRC_URI_append =` and `SRC_URI +=` is the same and if I am not mistaken
> the manual says the same [1].
> 
> Do I understand your patch correctly, that when `_append` was used in
> the recipe in some places, the space was missing and that you chose to
> replace it by `+=` for consistency?

Yes. I think that += is easier to use and less error-prone.

- As Koen already pointed out, it adds whitespace automatically, so in
whitespace separated lists like SRC_URI you don't have to care.

- You can use multiple statements in a recipe.

SRC_URI += "foo"
SRC_URI += "bar"

vs.

SRC_URI_append = " foo"
SRC_URI_append = " bar"

The latter wouldn't work.

In the case of gcc, I modified SRC_URI in some inc file resulting in
"... file://my.patchfile://fortran-cross-compile-hack.patch ...".

> [1] http://docs.openembedded.org/usermanual/usermanual.html#recipes_syntax

SRC_URI_append = "file://fixup.patch" is probably a bad example.

Regards,
Andreas