From: Nishanth Menon <nm@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-omap@vger.kernel.org, "Gopinath, Thara" <thara@ti.com>
Subject: Re: Latest regressions
Date: Fri, 07 Jan 2011 06:58:25 -0600 [thread overview]
Message-ID: <4D270DF1.8060804@ti.com> (raw)
In-Reply-To: <20110107115744.GL1198@n2100.arm.linux.org.uk>
Russell King - ARM Linux wrote, on 01/07/2011 05:57 AM:
> In file included from arch/arm/plat-omap/include/plat/omap_hwmod.h:37,
> from arch/arm/mach-omap2/io.c:45:
> arch/arm/plat-omap/include/plat/voltage.h: In function ■omap_voltage_register_pmic■:
> arch/arm/plat-omap/include/plat/voltage.h:137: warning: no return statement in function returning non-void
>
> which gets spammed out all through the build. voltage.h:137 says:
>
> static inline int omap_voltage_register_pmic(struct voltagedomain *voltdm,
> struct omap_volt_pmic_info *pmic_info) {}
>
> but no one checks the return value for this:
>
> arch/arm/mach-omap2/omap_twl.c: omap_voltage_register_pmic(voltdm,&omap4_mpu_volt_info);
> arch/arm/mach-omap2/omap_twl.c: omap_voltage_register_pmic(voltdm,&omap4_iva_volt_info);
> arch/arm/mach-omap2/omap_twl.c: omap_voltage_register_pmic(voltdm,&omap4_core_volt_info);
> arch/arm/mach-omap2/omap_twl.c: omap_voltage_register_pmic(voltdm,&omap3_mpu_volt_info);
> arch/arm/mach-omap2/omap_twl.c: omap_voltage_register_pmic(voltdm,&omap3_core_volt_info);
>
> so I don't see the point of it returning an 'int'.
intent was that in the future the volt_info would be validated and users
will check as well.
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-07 12:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 11:57 Latest regressions Russell King - ARM Linux
2011-01-07 12:58 ` Nishanth Menon [this message]
2011-01-07 14:41 ` Russell King - ARM Linux
2011-01-07 14:54 ` Santosh Shilimkar
2011-01-07 14:57 ` Russell King - ARM Linux
2011-01-07 17:12 ` Tony Lindgren
2011-01-07 16:56 ` Tony Lindgren
2011-01-07 21:56 ` Kevin Hilman
2011-01-26 8:58 ` Russell King - ARM Linux
2011-01-26 18:12 ` Tony Lindgren
2011-01-27 12:22 ` Russell King - ARM Linux
2011-01-28 0:18 ` Tony Lindgren
2011-01-28 0:21 ` Tony Lindgren
2011-01-28 0:24 ` Tony Lindgren
2011-01-26 9:01 ` Russell King - ARM Linux
2011-01-26 18:15 ` Tony Lindgren
2011-01-27 12:22 ` Russell King - ARM Linux
2011-01-28 0:22 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D270DF1.8060804@ti.com \
--to=nm@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=thara@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.