From: Nishanth Menon <nm@ti.com>
To: Sanjeev Premi <premi@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap3: Add basic support for 720MHz part
Date: Fri, 07 Jan 2011 07:33:34 -0600 [thread overview]
Message-ID: <4D27162E.6070203@ti.com> (raw)
In-Reply-To: <1294405659-25662-1-git-send-email-premi@ti.com>
Sanjeev Premi wrote, on 01/07/2011 07:07 AM:
> + if (omap3_has_720mhz()) {
> + pr_info("Enabled OPP corresponding to 720MHz\n");
> +
> + omap34xx_opp_def_list[INDEX_MPU_720MHZ]
> + .default_available = true;
> + omap34xx_opp_def_list[INDEX_IVA_720MHZ]
> + .default_available = true;
for many reasons, I dont like this indexing - I am ok with most part of
the patch otherwise - how about opp_enable(dev, freq) instead?
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2011-01-07 13:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 13:07 [PATCH] omap3: Add basic support for 720MHz part Sanjeev Premi
2011-01-07 13:33 ` Nishanth Menon [this message]
2011-01-07 13:50 ` Premi, Sanjeev
2011-01-07 14:04 ` Nishanth Menon
2011-01-07 16:48 ` Kevin Hilman
2011-01-07 17:31 ` Premi, Sanjeev
-- strict thread matches above, loose matches on Subject: below --
2011-01-18 7:49 Sanjeev Premi
2011-01-18 9:14 ` Varadarajan, Charulatha
2011-01-20 10:58 ` Premi, Sanjeev
2011-01-20 11:12 ` Varadarajan, Charulatha
2011-01-20 11:20 ` G, Manjunath Kondaiah
2011-01-20 11:28 ` Premi, Sanjeev
2011-01-18 15:38 ` Koen Kooi
2011-01-18 16:49 ` Nishanth Menon
2011-01-18 17:18 ` Vishwanath Sripathy
2011-01-18 18:17 ` Koen Kooi
2011-01-19 8:56 ` Vishwanath Sripathy
2011-01-19 9:06 ` Nishanth Menon
2011-01-19 9:49 ` Koen Kooi
2011-01-19 10:19 ` Premi, Sanjeev
2011-01-19 9:49 ` Premi, Sanjeev
2011-01-19 9:51 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D27162E.6070203@ti.com \
--to=nm@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.