From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 2/8] Add default error path for get_property
Date: Fri, 07 Jan 2011 14:49:16 +0100 [thread overview]
Message-ID: <4D2719DC.1030008@redhat.com> (raw)
In-Reply-To: <20110107134141.GC5910@agk-dp.fab.redhat.com>
Dne 7.1.2011 14:41, Alasdair G Kergon napsal(a):
> On Fri, Jan 07, 2011 at 12:17:30PM +0100, Zdenek Kabelac wrote:
>> + log_errno(EINVAL, "Invalid query for property.");
>
> Do we have any information about the property to include in that error
> message, such as its name?
>
No - all parameters passed to get_property are NULL in this case -
so programmer's error.
Zdenek
next prev parent reply other threads:[~2011-01-07 13:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 11:17 [PATCH 0/8] Fixes and speedups Zdenek Kabelac
2011-01-07 11:17 ` [PATCH 1/8] Add support for OCF dir selection Zdenek Kabelac
2011-01-07 13:39 ` Alasdair G Kergon
2011-01-07 11:17 ` [PATCH 2/8] Add default error path for get_property Zdenek Kabelac
2011-01-07 13:41 ` Alasdair G Kergon
2011-01-07 13:49 ` Zdenek Kabelac [this message]
2011-01-07 13:55 ` Alasdair G Kergon
2011-01-07 15:03 ` Zdenek Kabelac
2011-01-08 22:20 ` Dave Wysochanski
2011-01-07 11:17 ` [PATCH 3/8] Change import_vg_from_buffer to use config_tree Zdenek Kabelac
2011-01-07 13:44 ` Alasdair G Kergon
2011-01-07 11:17 ` [PATCH 4/8] Cache config_tree Zdenek Kabelac
2011-01-07 13:45 ` Alasdair G Kergon
2011-01-07 11:17 ` [PATCH 5/8] Define DM_COOKIE_AUTO_CREATE Zdenek Kabelac
2011-01-07 13:47 ` Alasdair G Kergon
2011-01-07 11:17 ` [PATCH 6/8] Add internal fs cookie Zdenek Kabelac
2011-01-07 13:51 ` Alasdair G Kergon
2011-01-07 11:17 ` [PATCH 7/8] Stop calling fs_unlock() and dm_udev_wait() Zdenek Kabelac
2011-01-07 14:16 ` Alasdair G Kergon
2011-01-07 11:17 ` [PATCH 8/8] Add fs_unlock calls Zdenek Kabelac
2011-01-07 14:20 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2719DC.1030008@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.