From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Manjunath Hadli <manjunath.hadli@ti.com>
Cc: LMML <linux-media@vger.kernel.org>,
Kevin Hilman <khilman@deeprootsystems.com>,
dlos <davinci-linux-open-source@linux.davincidsp.com>,
linux-arm-kernel@listinfradead.com,
Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: [PATCH v12 5/8] davinci vpbe: platform specific additions
Date: Fri, 07 Jan 2011 16:57:37 +0300 [thread overview]
Message-ID: <4D271BD1.30405@mvista.com> (raw)
In-Reply-To: <1294407622-25670-1-git-send-email-manjunath.hadli@ti.com>
Hello.
On 07-01-2011 16:40, Manjunath Hadli wrote:
> This patch implements the overall device creation for the Video
> display driver.
> Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com>
> Acked-by: Muralidharan Karicheri<m-karicheri2@ti.com>
> Acked-by: Hans Verkuil<hverkuil@xs4all.nl>
[...]
> diff --git a/arch/arm/mach-davinci/include/mach/dm644x.h b/arch/arm/mach-davinci/include/mach/dm644x.h
> index 5a1b26d..b59591c 100644
> --- a/arch/arm/mach-davinci/include/mach/dm644x.h
> +++ b/arch/arm/mach-davinci/include/mach/dm644x.h
> @@ -6,8 +6,7 @@
> *
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> + * the Free Software Foundation; either version 2 of the License.
Unfinished sentence. Did you intend to changed the license to GPL 2 only?
If so, it's worth mentioning in the changelog...
[...]
> @@ -40,8 +43,21 @@
> #define DM644X_ASYNC_EMIF_DATA_CE2_BASE 0x06000000
> #define DM644X_ASYNC_EMIF_DATA_CE3_BASE 0x08000000
>
> +/* VPBE register base addresses */
> +#define DM644X_VENC_REG_BASE 0x01C72400
You defined the macro but don't use it...
> +#define DM644X_VPBE_REG_BASE 0x01C72780
> +
> +#define DM644X_OSD_REG_BASE 0x01C72600
Same comment...
> +#define DM644X_VPBE_REG_BASE 0x01C72780
This is duplicate.
> +
> +#define OSD_REG_SIZE 0x00000100
Your OSD platform device however has its resource of size 0x200...
> +/* SYS register addresses */
> +#define SYS_VPSS_CLKCTL 0x01C40044
You've already #define'd and used VPSS_CLKCTL -- this is duplicate/unused.
WBR, Sergei
next prev parent reply other threads:[~2011-01-07 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 13:40 [PATCH v12 5/8] davinci vpbe: platform specific additions Manjunath Hadli
2011-01-07 13:57 ` Sergei Shtylyov [this message]
2011-01-07 14:13 ` Hadli, Manjunath
2011-01-07 14:19 ` Sergei Shtylyov
2011-01-07 14:30 ` Hadli, Manjunath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D271BD1.30405@mvista.com \
--to=sshtylyov@mvista.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@listinfradead.com \
--cc=linux-media@vger.kernel.org \
--cc=manjunath.hadli@ti.com \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.