From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42483 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PbLwJ-0008HL-Dr
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 18:41:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth@twiddle.net>) id 1PbLwI-000687-Ev
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 18:41:47 -0500
Received: from b.mail.sonic.net ([64.142.19.5]:51000)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth@twiddle.net>) id 1PbLwI-00067z-7x
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 18:41:46 -0500
Message-ID: <4D27A4AC.5060503@twiddle.net>
Date: Fri, 07 Jan 2011 15:41:32 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/7] tcg-hppa: Implement deposit operation.
References: <1294440183-885-1-git-send-email-rth@twiddle.net>	<1294440183-885-4-git-send-email-rth@twiddle.net>
	<20110107233503.GA20743@zubnet.me.uk>
In-Reply-To: <20110107233503.GA20743@zubnet.me.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stuart Brady <sdb@zubnet.me.uk>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>, Alexander Graf <agraf@suse.de>

On 01/07/2011 03:35 PM, Stuart Brady wrote:
>> +static inline void tcg_out_depi(TCGContext *s, int ret, int arg,
>                                                                ^^^
>> +                                unsigned ofs, unsigned len)
>> +{
>> +    assert(ofs < 32 && len <= 32 - ofs);
>> +    tcg_out32(s, INSN_DEPI | INSN_R2(ret) | INSN_IM5(val)
>                                                         ^^^
> 
> The parameter should be named val, too.

Oops.  It seems I failed to push that trivial change back from the gcc farm test box.

>> +            if (const_args[1]) {
> 
> Surely const_args[1] && arg1 == 0?

This is implied by the "Z" constraint used.


r~