From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36192 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pc1XJ-0005DM-Fi
	for qemu-devel@nongnu.org; Sun, 09 Jan 2011 15:06:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <martin.mohring@opensuse.org>) id 1Pc1XI-0002xu-G3
	for qemu-devel@nongnu.org; Sun, 09 Jan 2011 15:06:45 -0500
Received: from dd21438.kasserver.com ([85.13.141.110]:56661)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <martin.mohring@opensuse.org>) id 1Pc1XI-0002xN-AK
	for qemu-devel@nongnu.org; Sun, 09 Jan 2011 15:06:44 -0500
Message-ID: <4D2A1550.6070704@opensuse.org>
Date: Sun, 09 Jan 2011 21:06:40 +0100
From: Martin Mohring <martin.mohring@opensuse.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/7] linux-user: Implement FS_IOC_FIEMAP ioctl
References: <cover.1294433287.git.riku.voipio@nokia.com>	<285da2b9a83353703d07e141fdb447e82944146c.1294433287.git.riku.voipio@nokia.com>	<AANLkTimZHVe0X8mT481-eQDATusZGECG124LmijXsKxX@mail.gmail.com>
	<4D29F4A0.1050500@iki.fi>
In-Reply-To: <4D29F4A0.1050500@iki.fi>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: riku voipio <riku.voipio@iki.fi>, Blue Swirl <blauwirbel@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On 01/09/2011 06:47 PM, riku voipio wrote:
> On 01/09/2011 04:47 PM, Blue Swirl wrote:
>> This fails if the file doesn't exist:
>>    CC    i386-linux-user/syscall.o
>> /src/qemu/linux-user/syscall.c:86:26: error: linux/fiemap.h: No such
>> file or directory
>
>> The fix is to introduce a feature check in configure.
>
> Perhaps we can do without configure check, since FS_IOC_FIEMAP is
> defined in fs.h if fiemap.h is available. See the attached patch.


I have cross checked building on any Debian, Fedora, Ubuntu and openSUSE
hosts I could try for x86 32bit and 64bit hosts and can confirm this
variant works of course on these.


I would also be very interested if you could apply my 2 line linux-user
change for loop mount ioctl I sent to the ml (yesterday).