[PATCH] Fix stubdom-dm using "grep" improperly

[John Weekes <lists.xen@nuclearfallout.net>]

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

stubdom-dm uses "grep" on "xm list" output to determine whether it is 
already running. The existing behavior is to use "grep $domname-dm" but 
this will result in a false-positive in the case of another domU running 
whose name ends with the full new name; for instance, if "abctest-dm" is 
running, a new "test-dm" will spin forever, waiting for it the end.

Any easy fix is to have it use "grep -w" instead of "grep", searching 
for the whole word only.

It also might be worth considering a switch to "xl list" from "xm list", 
here and in other places.

This bug appears to exist in xen-4.0-testing, as well.

Since it's a one-liner, a signed-off may not be needed, but just in case..

Signed-off-by: John Weekes <lists.xen@nuclearfallout.net>

--- a/xen-unstable.hg/stubdom/stubdom-dm        2010-08-10 
23:20:26.187051097 -0500
+++ b/xen-unstable.hg/stubdom/stubdom-dm        2011-01-09 
22:43:15.951806650 -0600
@@ -91,7 +91,7 @@
  ############
  # stubdomain
  # Wait for any previous stubdom to terminate
-while xm list | grep $domname-dm
+while xm list | grep -w $domname-dm
  do
         sleep 1
  done

[-- Attachment #2: stubdom-dm.patch --]
[-- Type: text/x-patch, Size: 337 bytes --]

--- a/xen-unstable.hg/stubdom/stubdom-dm	2010-08-10 23:20:26.187051097 -0500
+++ b/xen-unstable.hg/stubdom/stubdom-dm	2011-01-09 22:43:15.951806650 -0600
@@ -91,7 +91,7 @@
 ############
 # stubdomain
 # Wait for any previous stubdom to terminate
-while xm list | grep $domname-dm
+while xm list | grep -w $domname-dm
 do
 	sleep 1
 done

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel