From: Pekka Enberg <penberg@kernel.org>
To: Michael Cree <mcree@orcon.net.nz>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
Matt Turner <mattst88@gmail.com>, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Bob Tracy <rct@gherkin.frus.com>,
David Woodhouse <David.Woodhouse@intel.com>
Subject: Re: [PATCH] i2c-i801: Add missing <linux/slab.h> include.
Date: Mon, 10 Jan 2011 08:46:20 +0200 [thread overview]
Message-ID: <4D2AAB3C.1080009@kernel.org> (raw)
In-Reply-To: <1294634675-29557-1-git-send-email-mcree@orcon.net.nz>
On 1/10/11 6:44 AM, Michael Cree wrote:
> Causes compile error on Alpha, but not on x86 because its version
> of<asm/pci.h> includes<linux/slab.h>. In any case, it's a bug
> in the driver.
>
> Signed-off-by: Michael Cree<mcree@orcon.net.nz>
Acked-by: Pekka Enberg <penberg@kernel.org>
> ---
>
> Since no one else has submitted the patch here it goes. Shall I send it
> directly to Linus (since I plan to send some Alpha specific patches very
> soon) or will the subsytem maintainers pick it up?
I'd let Andrew sort it out. (hi Andrew! ;-)
> drivers/i2c/busses/i2c-i801.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 02835ce..7979aef 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -72,6 +72,7 @@
> #include<linux/acpi.h>
> #include<linux/io.h>
> #include<linux/dmi.h>
> +#include<linux/slab.h>
>
> /* I801 SMBus address offsets */
> #define SMBHSTSTS(p) (0 + (p)->smba)
next prev parent reply other threads:[~2011-01-10 6:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 6:18 [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha Bob Tracy
2011-01-04 7:15 ` Pekka Enberg
2011-01-04 7:15 ` Pekka Enberg
2011-01-04 19:37 ` Matt Turner
2011-01-04 19:37 ` Matt Turner
2011-01-04 20:56 ` Pekka Enberg
2011-01-04 20:56 ` Pekka Enberg
2011-01-04 22:11 ` Randy Dunlap
2011-01-04 22:11 ` Randy Dunlap
2011-01-10 4:44 ` [PATCH] i2c-i801: Add missing <linux/slab.h> include Michael Cree
2011-01-10 6:46 ` Pekka Enberg [this message]
2011-01-10 14:03 ` Bob Tracy
2011-01-04 22:04 ` [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha Bob Tracy
2011-01-04 21:10 ` Maciej Rutecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2AAB3C.1080009@kernel.org \
--to=penberg@kernel.org \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mcree@orcon.net.nz \
--cc=randy.dunlap@oracle.com \
--cc=rct@gherkin.frus.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.