From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] common: introduce a genutils.h file
Date: Mon, 10 Jan 2011 08:09:05 +0100 [thread overview]
Message-ID: <4D2AB091.9030405@denx.de> (raw)
In-Reply-To: <20110109164626.BC660127@gemini.denx.de>
Hello Wolfgang,
Wolfgang Denk wrote:
> In message <1292232393-26481-1-git-send-email-hs@denx.de> you wrote:
>> as discussed in thread
>> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/76654
>>
>> and as a result of this discussion Michael Zaidman
>> proposed to create a genutils.h, see:
>>
>> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/78692
>>
>> So, introduce this genutils.h, as BUILD_BUG_ON is also
>> needed in sensor support.
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> cc: Michael Zaidman <michael.zaidman@gmail.com>
>> ---
>> maybe I should include genutils.h in common.h ?
>>
>> include/genutils.h | 30 ++++++++++++++++++++++++++++++
>
> I do not like the idea of adding yet another nonstandard header file
> with just a few definitions in it.
>
> Linux defines this is include/linux/kernel.h, i. e. in a pretty
> central place, and we should porobably do the same.
>
> How about adding it to include/common.h instead?
Hmm.. I thought exactly this should not go in common.h as a
result from this thread:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/78692
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-01-10 7:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 14:00 [U-Boot] [PATCH][NEXT] hwmon: do not init sensors on startup Heiko Schocher
2010-12-09 14:26 ` Wolfgang Denk
2010-12-09 15:45 ` Heiko Schocher
2010-12-09 18:50 ` Wolfgang Denk
2010-12-13 9:26 ` [U-Boot] [PATCH 1/2] common: introduce a genutils.h file Heiko Schocher
2011-01-09 16:46 ` Wolfgang Denk
2011-01-10 7:09 ` Heiko Schocher [this message]
2011-01-10 10:19 ` Wolfgang Denk
2011-06-09 9:07 ` [U-Boot] [PATCH v3 1/2] common: move BUILD_BUG_ON define to common.h Heiko Schocher
2011-07-27 21:46 ` Wolfgang Denk
2010-12-13 9:26 ` [U-Boot] [PATCH 2/2 v2] hwmon: do not init sensors on startup Heiko Schocher
2011-01-09 16:49 ` Wolfgang Denk
2011-06-09 9:07 ` [U-Boot] [PATCH v3 2/2] " Heiko Schocher
2011-08-01 7:23 ` Holger Brunck
2011-08-01 10:13 ` Wolfgang Denk
2011-08-01 10:12 ` Wolfgang Denk
2011-08-01 11:08 ` [U-Boot] [PATCH v4 " Heiko Schocher
2011-08-01 13:28 ` Wolfgang Denk
2011-08-01 13:54 ` Heiko Schocher
2011-08-01 14:01 ` [U-Boot] [PATCH v5 " Heiko Schocher
2011-08-04 21:31 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2AB091.9030405@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.