From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Manjunath Hadli <manjunath.hadli@ti.com>
Cc: LMML <linux-media@vger.kernel.org>,
Kevin Hilman <khilman@deeprootsystems.com>,
dlos <davinci-linux-open-source@linux.davincidsp.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: [PATCH v13 5/8] davinci vpbe: platform specific additions
Date: Mon, 10 Jan 2011 14:28:41 +0300 [thread overview]
Message-ID: <4D2AED69.3060602@mvista.com> (raw)
In-Reply-To: <1294654980-1936-1-git-send-email-manjunath.hadli@ti.com>
Hello.
On 10-01-2011 13:23, Manjunath Hadli wrote:
> This patch implements the overall device creation for the Video
> display driver.
> Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com>
> Acked-by: Muralidharan Karicheri<m-karicheri2@ti.com>
> Acked-by: Hans Verkuil<hverkuil@xs4all.nl>
[...]
> diff --git a/arch/arm/mach-davinci/dm644x.c b/arch/arm/mach-davinci/dm644x.c
> index 9a2376b..3cc5f7c 100644
> --- a/arch/arm/mach-davinci/dm644x.c
> +++ b/arch/arm/mach-davinci/dm644x.c
[...]
> @@ -654,6 +655,138 @@ void dm644x_set_vpfe_config(struct vpfe_config *cfg)
[...]
> +
> +#define VPSS_CLKCTL SYS_VPSS_CLKCTL
What's the point? Why not just use SYS_VPSS_CLKCTL?
> diff --git a/arch/arm/mach-davinci/include/mach/dm644x.h b/arch/arm/mach-davinci/include/mach/dm644x.h
> index 5a1b26d..46385e7 100644
> --- a/arch/arm/mach-davinci/include/mach/dm644x.h
> +++ b/arch/arm/mach-davinci/include/mach/dm644x.h
[...]
> @@ -40,8 +43,19 @@
> #define DM644X_ASYNC_EMIF_DATA_CE2_BASE 0x06000000
> #define DM644X_ASYNC_EMIF_DATA_CE3_BASE 0x08000000
>
> +/* VPBE register base addresses */
> +#define DM644X_VENC_REG_BASE 0x01C72400
> +#define DM644X_OSD_REG_BASE 0x01C72600
> +
> +#define OSD_REG_SIZE 0x000001ff
> +#define VENC_REG_SIZE 0x0000017f
Well, actually that's not the size but "limit" -- sizes should be 0x200
and 0x180 respectively...
WBR, Sergei
next prev parent reply other threads:[~2011-01-10 11:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 10:23 [PATCH v13 5/8] davinci vpbe: platform specific additions Manjunath Hadli
2011-01-10 11:28 ` Sergei Shtylyov [this message]
2011-01-10 11:55 ` Nori, Sekhar
2011-01-10 12:51 ` Hadli, Manjunath
2011-01-10 12:55 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2AED69.3060602@mvista.com \
--to=sshtylyov@mvista.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-media@vger.kernel.org \
--cc=manjunath.hadli@ti.com \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.