From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] ARM: pxa: Fix recursive call of pxa_(un)mask_low_gpio()
Date: Mon, 10 Jan 2011 15:04:58 +0300 [thread overview]
Message-ID: <4D2AF5EA.6050104@ru.mvista.com> (raw)
In-Reply-To: <1294615746-27668-5-git-send-email-marek.vasut@gmail.com>
Hello.
On 10-01-2011 2:29, Marek Vasut wrote:
> Signed-off-by: Marek Vasut<marek.vasut@gmail.com>
[...]
> diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
> index 81edf97..96571fe 100644
> --- a/arch/arm/mach-pxa/irq.c
> +++ b/arch/arm/mach-pxa/irq.c
> @@ -112,14 +112,14 @@ static void pxa_mask_low_gpio(unsigned int irq)
> {
> struct irq_desc *desc = irq_to_desc(irq);
You should have removed that variable too as it's not unused.
> - desc->chip->mask(irq);
> + pxa_mask_irq(irq);
> }
>
> static void pxa_unmask_low_gpio(unsigned int irq)
> {
> struct irq_desc *desc = irq_to_desc(irq);
Same here...
> - desc->chip->unmask(irq);
> + pxa_unmask_irq(irq);
> }
WBR, Sergei
next prev parent reply other threads:[~2011-01-10 12:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-09 23:29 [PATCH 1/5] pxa: Fix warning in zeus.c Marek Vasut
2011-01-09 23:29 ` [PATCH 2/5] pxa: Remove unused variable in clock-pxa3xx.c Marek Vasut
2011-01-10 22:42 ` Eric Miao
2011-01-09 23:29 ` [PATCH 3/5] ARM: pxa: Use cpu_has_ipr() consistently in irq.c Marek Vasut
2011-01-10 22:43 ` Eric Miao
2011-01-09 23:29 ` [PATCH 4/5] ARM: pxa: Fix suspend/resume array index miscalculation Marek Vasut
2011-01-10 12:09 ` Sergei Shtylyov
2011-01-10 22:49 ` Eric Miao
2011-01-10 23:13 ` Marek Vasut
2011-01-09 23:29 ` [PATCH 5/5] ARM: pxa: Fix recursive call of pxa_(un)mask_low_gpio() Marek Vasut
2011-01-10 12:04 ` Sergei Shtylyov [this message]
2011-01-10 22:40 ` [PATCH 1/5] pxa: Fix warning in zeus.c Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2AF5EA.6050104@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.