From: Shinya Kuribayashi <skuribay@pobox.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 0/8] those series patches for add ben nanonote board
Date: Mon, 10 Jan 2011 22:33:17 +0900 [thread overview]
Message-ID: <4D2B0A9D.8030107@pobox.com> (raw)
In-Reply-To: <1294589925-32639-1-git-send-email-xiangfu@openmobilefree.net>
Thanks for keeping on working on jz4740 patchset.
On 01/10/2011 01:18 AM, Xiangfu Liu wrote:
> Hi Wolfgang
> those patches are for add xburst jz4740 and Ben NanoNote(named qi_lb60) to U-Boot
>
> some info about xburst jz4740:
> the xburst jz4740 is recently added to linux 2.6.36
> and it's support the device Ben NanoNote out of box,
:
:
Very useful comments, so such info should also be put into patch
description of the relevant changes; Jz4740 SoC overview and about USB
boot, respectively.
> ====
> FIXED in [PATCH v3]
> 1. describe what Jz4740 SoC
> 2. remove the ENDIANNESS in config.mk
> 3. don't breaks the 80-charcter-wide rule
> 4. get rid of #if 0
> 5. use proper I/O accessors to access registers.
> 6. remove C++ comments, cleanup code style.
>
> FIXED in [PATCH v4]
> 1. add Entry to MAINTAINERS and boards.cfg
> 2. add ben nanonote(qi_lb60) to Makefile
> 3. tested with CROSS_COMPILE=mips_4KCle- ./MAKEALL mips_el
>
> FIXED in [PATCH v5]
> 1. remove nand_spl/nand_boot_jz4740.c
> 2. some cleanup
Having a quick glance, v5 still has issues (e.g. it gets split into
8 patches in an improper way). I'll have a closer look later.
By the way, I've uploaded xl/jz4740-ben-nanonote-v5 branch (and older
v2/v3/v4 branches as well) to make reviews easier for involved people.
prev parent reply other threads:[~2011-01-10 13:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-09 16:18 [U-Boot] [PATCH v5 0/8] those series patches for add ben nanonote board Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 1/8] those files are jz4740 base files Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 2/8] this is jz4740 head file Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 3/8] jz4740 nand spl files Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 4/8] jz4740 nand driver Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 5/8] add Ben NanoNote board Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 6/8] add entry to MAINTAINERS and boards.cfg Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 7/8] modify files for ben nanonote board Xiangfu Liu
2011-01-09 16:18 ` [U-Boot] [PATCH v5 8/8] add software usbboot Xiangfu Liu
2011-01-17 21:36 ` [U-Boot] [PATCH v5 2/8] this is jz4740 head file Wolfgang Denk
2011-01-17 21:35 ` [U-Boot] [PATCH v5 1/8] those files are jz4740 base files Wolfgang Denk
2011-02-28 4:54 ` Xiangfu Liu
2011-02-28 6:36 ` Xiangfu Liu
2011-01-10 13:33 ` Shinya Kuribayashi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B0A9D.8030107@pobox.com \
--to=skuribay@pobox.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.