From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH] [v2] ASoC: cs4270: use the built-in register cache support Date: Mon, 10 Jan 2011 13:03:26 -0600 Message-ID: <4D2B57FE.4090401@freescale.com> References: <1294675292-6289-1-git-send-email-timur@freescale.com> <1294676990.11031.10.camel@dplaptop.localdomain> <4D2B34C1.7050209@freescale.com> <1294677365.11031.13.camel@dplaptop.localdomain> <4D2B4376.101@freescale.com> <20110110182302.GB26137@opensource.wolfsonmicro.com> <4D2B50FA.9060102@freescale.com> <20110110183615.GC26137@opensource.wolfsonmicro.com> <4D2B52DA.1090102@freescale.com> <20110110185406.GD26137@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from VA3EHSOBE009.bigfish.com (va3ehsobe006.messaging.microsoft.com [216.32.180.16]) by alsa0.perex.cz (Postfix) with ESMTP id 2BEFE245B6 for ; Mon, 10 Jan 2011 20:03:38 +0100 (CET) In-Reply-To: <20110110185406.GD26137@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, lrg@slimlogic.co.uk List-Id: alsa-devel@alsa-project.org Mark Brown wrote: > This is all code that's evolved over time, and originally there was no > readback facility at all (everything came from cache) so there were no > errors to report in the first place. Besides, in general there's > nothing constructive we can do about errors anyway except log them. Well, I'm not sure I agree. For one thing, the current code doesn't just fail to report I/O errors to the callers, it re-interprets an error code as valid date and plows right on ahead. In addition, there are places where getting a return code would be useful. I call snd_soc_update_bits() in my probe function, so that's a great opportunity to tell ASoC that this device is broken and it shouldn't instantiate a sound card. -- Timur Tabi Linux kernel developer at Freescale