From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v3 6/6] atmodem: implement query for remaining pin retries
Date: Mon, 10 Jan 2011 15:44:14 -0600 [thread overview]
Message-ID: <4D2B7DAE.5020505@gmail.com> (raw)
In-Reply-To: <1294693351-25475-7-git-send-email-lucas.demarchi@profusion.mobi>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
Hi Lucas,
> +static void at_pin_retries_query(struct ofono_sim *sim,
> + ofono_sim_pin_retries_cb_t cb, void *data)
> +{
> + struct sim_data *sd = ofono_sim_get_data(sim);
> +
> + DBG("");
> +
> + if (sd->vendor == OFONO_VENDOR_HUAWEI) {
> + struct cb_data *cbd = cb_data_new(cb, data);
> +
> + if (cbd == NULL) {
> + CALLBACK_WITH_FAILURE(cb, NULL, data);
> +
> + return;
> + }
> +
> + if (g_at_chat_send(sd->chat, "AT^CPIN?", huawei_cpin_prefix,
> + huawei_cpin_cb, cbd, g_free) > 0)
> + return;
> +
> + g_free(cbd);
> +
> + CALLBACK_WITH_FAILURE(cb, NULL, data);
> + }
> +
> + CALLBACK_WITH_SUCCESS(cb, NULL, data);
I believe this will cause the core to segfault when running on
non-huawei devices.
> +}
Regards,
-Denis
next prev parent reply other threads:[~2011-01-10 21:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 21:02 [PATCH v3 0/6] Query retry counters Lucas De Marchi
2011-01-10 21:02 ` [PATCH v3 1/6] atmodem: check for VENDOR_HUAWEI on sim atom Lucas De Marchi
2011-01-10 21:02 ` [PATCH v3 2/6] huawei: use VENDOR_HUAWEI quirk on sim creation Lucas De Marchi
2011-01-10 21:02 ` [PATCH v3 3/6] include: add method to query pin Retries Lucas De Marchi
2011-01-10 21:02 ` [PATCH v3 4/6] sim: query remaining pin retries Lucas De Marchi
2011-01-10 21:02 ` [PATCH v3 5/6] doc: detail Retries property Lucas De Marchi
2011-01-10 21:02 ` [PATCH v3 6/6] atmodem: implement query for remaining pin retries Lucas De Marchi
2011-01-10 21:44 ` Denis Kenzior [this message]
2011-01-10 21:43 ` [PATCH v3 0/6] Query retry counters Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B7DAE.5020505@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.