Hi Dara,

> +static void nokiacdma_remove(struct ofono_modem *modem)
> +{
> +	struct nokiacdma_data *data = ofono_modem_get_data(modem);
> +
> +	DBG("%p", modem);
> +
> +	ofono_modem_set_data(modem, NULL);
> +
> +	if (data->chat)
> +		g_at_chat_unref(data->chat);

Feel free to skip the NULL check, g_at_chat_unref handles this just fine.

> +
> +	g_free(data);
> +}
> +

<snip>

> +static gboolean nokiacdma_set_online_cb(gpointer cb_data)
> +{
> +	struct cb_data *cbd = cb_data;
> +	ofono_modem_online_cb_t cb = cbd->cb;
> +
> +	CALLBACK_WITH_SUCCESS(cb, cbd->data);
> +
> +	g_free(cbd);
> +
> +	/* do not call again */
> +	return FALSE;
> +}
> +
> +static void nokiacdma_set_online(struct ofono_modem *modem,
> +				ofono_bool_t online,
> +				ofono_modem_online_cb_t cb, void *user_data)
> +{
> +	struct cb_data *cbd = cb_data_new(cb, user_data);
> +
> +	DBG("modem %p %s", modem, online ? "online" : "offline");
> +
> +	/* TODO: Add implementation to control modem online status */
> +	g_idle_add(nokiacdma_set_online_cb, cbd);
> +}
> +

I'm really lost in the above two functions.  If you don't have an
implementation, you can just skip it.  oFono should do the right thing
and automatically bring devices up into online state if set_online is
missing.

Regards,
-Denis