All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shan Wei <shanwei@cn.fujitsu.com>
To: linux-sctp@vger.kernel.org
Subject: Re: [PATCH 1/2] sctp: Remove variables that are only written to
Date: Tue, 11 Jan 2011 01:18:02 +0000	[thread overview]
Message-ID: <4D2BAFCA.6030501@cn.fujitsu.com> (raw)
In-Reply-To: <1294657090-2789-2-git-send-email-holger@freyther.de>

Holger Hans Peter Freyther wrote, at 01/10/2011 06:58 PM:
> From: Holger Hans Peter Freyther <zecke@selfish.org>
> 
> The following variables only get a simple assignment but
> are never read from. Remove these variables.
> 
> Signed-off-by: Holger Hans Peter Freyther <zecke@selfish.org>
> ---
> diff --git a/net/sctp/input.c b/net/sctp/input.c
> index 471e048..e052243 100644
> --- a/net/sctp/input.c
> +++ b/net/sctp/input.c
> @@ -986,14 +986,11 @@ static struct sctp_association *__sctp_rcv_init_lookup(struct sk_buff *skb,
>  	union sctp_addr addr;
>  	union sctp_addr *paddr = &addr;
>  	struct sctphdr *sh = sctp_hdr(skb);
> -	sctp_chunkhdr_t *ch;
>  	union sctp_params params;
>  	sctp_init_chunk_t *init;
>  	struct sctp_transport *transport;
>  	struct sctp_af *af;
>  
> -	ch = (sctp_chunkhdr_t *) skb->data;
> -
>  	/*
>  	 * This code will NOT touch anything inside the chunk--it is
>  	 * strictly READ-ONLY.

This part has been submmited in a patch.

See:http://git.kernel.org/?p=linux/kernel/git/vxy/lksctp-dev.git;a=commitdiff;hJ5161a90560703ca1a720aca3081e6f5a43395c;hpz86dbe071e6d9d7d3446c140275c483ec8db639

-- 
Best Regards
-----
Shan Wei

      reply	other threads:[~2011-01-11  1:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10 10:58 [PATCH 1/2] sctp: Remove variables that are only written to Holger Hans Peter Freyther
2011-01-11  1:18 ` Shan Wei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2BAFCA.6030501@cn.fujitsu.com \
    --to=shanwei@cn.fujitsu.com \
    --cc=linux-sctp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.