From: Trilok Soni <tsoni@codeaurora.org>
To: Rakesh Iyer <riyer@nvidia.com>
Cc: "jj@chaosbits.net" <jj@chaosbits.net>,
"shubhrajyoti@ti.com" <shubhrajyoti@ti.com>,
"ccross@android.com" <ccross@android.com>,
"konkers@android.com" <konkers@android.com>,
"olof@lixom.net" <olof@lixom.net>, Andrew Chew <AChew@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH v3] input: tegra-kbc - Add tegra keyboard driver
Date: Tue, 11 Jan 2011 12:54:50 +0530 [thread overview]
Message-ID: <4D2C05C2.9040705@codeaurora.org> (raw)
In-Reply-To: <1FC56210173BB445BD77F608D6FB8D03165A00805E@HQMAIL03.nvidia.com>
Hi Rakesh,
On 1/11/2011 2:41 AM, Rakesh Iyer wrote:
> Thanks for the review.
>
> A quick response regarding the following comment.
>
>>
>>> +
>>> +#include <linux/module.h>
>>> +#include <linux/input.h>
>>> +#include <linux/platform_device.h>
>>> +#include <linux/delay.h>
>>> +#include <linux/io.h>
>>> +#include <linux/interrupt.h>
>>> +#include <linux/clk.h>
>>> +#include <linux/slab.h>
>>> +#include <mach/clk.h>
>>
>> You may not need this.
>>
>
> The mach/clk.h file contains declarations for tegra_periph_reset_assert and tegra_periph_reset_deassert which are needed.
It is really bad if it can't be addressed through clk framework. I will check this, but this
keyboard controller is on-chip so we should be fine I guess.
I hope that these APIs are not required for device drivers which are on external bus like I2C.
---Trilok Soni
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-01-11 7:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 17:45 [PATCH v3] input: tegra-kbc - Add tegra keyboard driver riyer
2011-01-10 19:40 ` Rakesh Iyer
2011-01-10 19:40 ` Rakesh Iyer
2011-01-10 20:53 ` Trilok Soni
2011-01-10 21:11 ` Rakesh Iyer
2011-01-11 7:24 ` Trilok Soni [this message]
2011-01-11 7:41 ` Colin Cross
2011-01-10 22:16 ` Dmitry Torokhov
2011-01-10 22:49 ` Rakesh Iyer
2011-01-10 23:06 ` Dmitry Torokhov
2011-01-11 19:34 ` Rakesh Iyer
2011-01-11 20:01 ` Dmitry Torokhov
2011-01-11 14:33 ` Pavel Machek
[not found] ` <AANLkTimUrKOX6ydXx8zUukk2+fBYQxEsp3=6qZwm5KRD@mail.gmail.com>
2011-01-10 23:33 ` Mohamed Ikbel Boulabiar
2011-01-10 23:56 ` Rakesh Iyer
2011-01-11 7:22 ` Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2C05C2.9040705@codeaurora.org \
--to=tsoni@codeaurora.org \
--cc=AChew@nvidia.com \
--cc=ccross@android.com \
--cc=jj@chaosbits.net \
--cc=konkers@android.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=riyer@nvidia.com \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.