Re: [PATCH] [rfc] ARM: mach-shmobile: mackerel: clarify shdi/mmcif

[Yusuke Goda <yusuke.goda.sx@renesas.com>]

Hi Simon-san

(2011/01/08 7:26), Simon Horman wrote:
> * Pins 2 and 4 of switch 33 are documented as don't care on the PCB,
>   my testing seems to confirm this.
I approve of your patch.
Pins 2 and 4 of switch 33 dont' care in mackerel.
There was a mistake in the Users Manual.
I asked a designer to revise Users Manual.
Thank you for your indication.

> * I have been unable to do anything sensible with S1 set to on.
>   Am I missing something with regards to MMC1?
SW1 ON : Can not use MCP(NOR, NAND) and Ether
Therefore, u-boot does not start.

> * Clarify which driver is needed for each switch setting.
> 
> * Should the AP4 board code be updated to allow the
>   SHDI driver to access SHDI1 as the mackerel code does?
In AP4, pins 2 and 4 of switch 33 should care.

Thanks,
Goda

> Signed-off-by: Simon Horman <horms@verge.net.au>
> ---
>  arch/arm/mach-shmobile/board-mackerel.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> index 42f7c0d..b190248 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -167,9 +167,8 @@
>   *	SW1	|	SW33
>   *		| bit1 | bit2 | bit3 | bit4
>   * -------------+------+------+------+-------
> - * MMC0	  OFF	|  OFF |  ON  |  ON  |  X
> - * MMC1	  ON	|  OFF |  ON  |  X   | ON
> - * SDHI1  OFF	|  ON  |   X  |  OFF | ON
> + * MMC0   OFF	|  OFF |   X  |  ON  |  X       (Use MMCIF)
> + * SDHI1  OFF	|  ON  |   X  |  OFF |  X       (Use MFD_SH_MOBILE_SDHI)
>   *
>   */
>