From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH 3/3] can: at91_can: make can_id of mailbox 0 configurable Date: Tue, 11 Jan 2011 12:45:52 +0100 Message-ID: <4D2C42F0.5080703@grandegger.com> References: <1294741688-22699-1-git-send-email-mkl@pengutronix.de> <1294741688-22699-4-git-send-email-mkl@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marc Kleine-Budde Return-path: In-Reply-To: <1294741688-22699-4-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On 01/11/2011 11:28 AM, Marc Kleine-Budde wrote: > Due to a chip bug (errata 50.2.6.3 & 50.3.5.3 in > "AT91SAM9263 Preliminary 6249H-ATARM-27-Jul-09") the contents of mailbox > 0 may be send under certain conditions (even if disabled or in rx mode). > > The workaround in the errata suggests not to use the mailbox and load it > with a unused identifier. > > This patch implements the second part of the workaround. A sysfs entry > "mb0_id" is introduced. While the interface is down it can be used to > configure the can_id of mailbox 0. The default value id 0x7ff. > > In order to use an extended can_id add the CAN_EFF_FLAG (0x80000000U) > to the can_id. Example: > > - standard id 0x7ff: > echo 0x7ff > /sys/class/net/can0/mb0_id > > - extended if 0x1fffffff: > echo 0x9fffffff > /sys/class/net/can0/mb0_id As this is a device specific property, I think it should go into /sys/class/net/can0/device/. Wolfgang.