All of lore.kernel.org
 help / color / mirror / Atom feed
From: gerg@snapgear.com (Greg Ungerer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: nommu: avoid mapping vectors page when !CONFIG_MMU
Date: Tue, 11 Jan 2011 22:33:09 +1000	[thread overview]
Message-ID: <4D2C4E05.7050608@snapgear.com> (raw)
In-Reply-To: <1294747337-18238-1-git-send-email-will.deacon@arm.com>

Hi Will,

On 11/01/11 22:02, Will Deacon wrote:
> When running without an MMU, we do not need to install a mapping for the
> vectors page. Attempting to do so causes a compile-time error because
> install_special_mapping is not defined.
>
> This patch adds compile-time guards to the vector mapping functions
> so that we can build nommu configurations once more.
>
> Cc: Greg Ungerer<gerg@uclinux.org>
> Signed-off-by: Will Deacon<will.deacon@arm.com>

I hit this a couple of days ago too, looks good.

Acked-by: Greg Ungerer <gerg@uclinux.org>

Regards
Greg


>   arch/arm/kernel/process.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index e76fcaa..94bbedb 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -483,6 +483,7 @@ unsigned long arch_randomize_brk(struct mm_struct *mm)
>   	return randomize_range(mm->brk, range_end, 0) ? : mm->brk;
>   }
>
> +#ifdef CONFIG_MMU
>   /*
>    * The vectors page is always readable from user space for the
>    * atomic helpers and the signal restart code.  Let's declare a mapping
> @@ -503,3 +504,4 @@ const char *arch_vma_name(struct vm_area_struct *vma)
>   {
>   	return (vma->vm_start == 0xffff0000) ? "[vectors]" : NULL;
>   }
> +#endif


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg at snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close,                            FAX:         +61 7 3891 3630
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com

  parent reply	other threads:[~2011-01-11 12:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-11 12:02 [PATCH] ARM: nommu: avoid mapping vectors page when !CONFIG_MMU Will Deacon
2011-01-11 12:13 ` Russell King - ARM Linux
2011-01-11 12:33 ` Greg Ungerer [this message]
2011-01-11 13:06   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2C4E05.7050608@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.