Re: [RFC PATCH 3/4] sim: add ofono_sim_get_mnc_length

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

Hi Marcel,

On 01/10/2011 06:40 PM, Marcel Holtmann wrote:
> Hi Jukka,
> 
>>  include/sim.h |    1 +
>>  src/sim.c     |    8 ++++++++
>>  2 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/sim.h b/include/sim.h
>> index 7860e24..9b21f2e 100644
>> --- a/include/sim.h
>> +++ b/include/sim.h
>> @@ -173,6 +173,7 @@ void ofono_sim_set_data(struct ofono_sim *sim, void *data);
>>  void *ofono_sim_get_data(struct ofono_sim *sim);
>>  
>>  const char *ofono_sim_get_imsi(struct ofono_sim *sim);
>> +unsigned int ofono_sim_get_mnc_length(struct ofono_sim *sim);
> 
> so here is now the question. Do we wanna make this simple and do it like
> this or just provide functions to the MCC and MNC like we do inside the
> network registration interface?
> 
> Denis, any favorites?
> 

From an API point of view providing the mnc and mcc directly is a better
idea.

Regards,
-Denis