From: Mourad De Clerck <mourad@aquazul.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Richard Purdie <rpurdie@linux.intel.com>,
linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>,
Richard Hughes <richard@hughsie.com>
Subject: mbp_nvidia_bl: Remove DMI dependency (was: Re: [PATCH,RESEND] backlight: mbp_nvidia_bl - add support for MacBookPro7,1)
Date: Tue, 11 Jan 2011 17:42:12 +0100 [thread overview]
Message-ID: <4D2C8864.8030909@aquazul.com> (raw)
In-Reply-To: <20110104143651.8f6d62e0.akpm@linux-foundation.org>
On 04/01/11 23:36, Andrew Morton wrote:
> I applied this, and now I'll unapply it because Matthew's patch series
> "mbp_nvidia_bl: Remove DMI dependency" appears to make your change
> obsolete.
>
> I'll cc you on those three patches - it will be great if you are able
> to find time to test them, thanks.
A bit late, but I tested this patch series and it works for me.
The only slight change is that gnome-power-manager needs to be updated
to use /sys/class/backlight/apple_backlight instead of mbp_backlight.
Thanks,
Mourad
PS: something like this, maybe?
--
diff --git a/src/gpm-backlight-helper.c b/src/gpm-backlight-helper.c
index 27aed09..a8ef608 100644
--- a/src/gpm-backlight-helper.c
+++ b/src/gpm-backlight-helper.c
@@ -58,6 +58,7 @@ gcm_backlight_helper_get_best_backlight ()
"thinkpad_screen",
"acpi_video1",
"mbp_backlight",
+ "apple_backlight",
"acpi_video0",
"fujitsu-laptop",
"sony",
next prev parent reply other threads:[~2011-01-11 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-24 8:49 [PATCH,RESEND] backlight: mbp_nvidia_bl - add support for MacBookPro7,1 Mourad De Clerck
2011-01-04 22:36 ` Andrew Morton
2011-01-11 16:42 ` Mourad De Clerck [this message]
2011-01-11 16:48 ` mbp_nvidia_bl: Remove DMI dependency (was: Re: [PATCH,RESEND] backlight: mbp_nvidia_bl - add support for MacBookPro7,1) Matthew Garrett
2011-01-11 17:05 ` Richard Hughes
2011-01-11 18:07 ` mbp_nvidia_bl: Remove DMI dependency Mourad De Clerck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2C8864.8030909@aquazul.com \
--to=mourad@aquazul.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=richard@hughsie.com \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.