From: Mike Christie <michaelc@cs.wisc.edu>
To: open-iscsi@googlegroups.com
Cc: kxie@chelsio.com, linux-scsi@vger.kernel.org,
James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH 1/2] cxgbi: set ulpmode only if digest is on
Date: Tue, 11 Jan 2011 14:24:59 -0600 [thread overview]
Message-ID: <4D2CBC9B.4000007@cs.wisc.edu> (raw)
In-Reply-To: <201101072245.p07Mjdea027574@localhost6.localdomain6>
On 01/07/2011 04:45 PM, kxie@chelsio.com wrote:
> [PATCH 1/2] cxgbi: set ulpmode only if digest is on
>
> From: Karen Xie<kxie@chelsio.com>
>
> There is need to set ulpmode on the tx skbs if no digest is enabled.
>
> Signed-off-by: Karen Xie<kxie@chelsio.com>
> ---
> drivers/scsi/cxgbi/libcxgbi.c | 17 ++++++++++-------
> 1 files changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
> index be56617..17dcada 100644
> --- a/drivers/scsi/cxgbi/libcxgbi.c
> +++ b/drivers/scsi/cxgbi/libcxgbi.c
> @@ -1908,13 +1908,16 @@ EXPORT_SYMBOL_GPL(cxgbi_conn_alloc_pdu);
>
> static inline void tx_skb_setmode(struct sk_buff *skb, int hcrc, int dcrc)
> {
> - u8 submode = 0;
> -
> - if (hcrc)
> - submode |= 1;
> - if (dcrc)
> - submode |= 2;
> - cxgbi_skcb_ulp_mode(skb) = (ULP2_MODE_ISCSI<< 4) | submode;
> + if (hcrc || dcrc) {
> + u8 submode = 0;
> +
> + if (hcrc)
> + submode |= 1;
> + if (dcrc)
> + submode |= 2;
> + cxgbi_skcb_ulp_mode(skb) = (ULP2_MODE_ISCSI<< 4) | submode;
> + } else
> + cxgbi_skcb_ulp_mode(skb) = 0;
> }
>
> int cxgbi_conn_init_pdu(struct iscsi_task *task, unsigned int offset,
>
Ok.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
prev parent reply other threads:[~2011-01-11 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 22:45 [PATCH 1/2] cxgbi: set ulpmode only if digest is on kxie
2011-01-07 22:50 ` Karen Xie
2011-01-11 20:24 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2CBC9B.4000007@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=kxie@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.