All of lore.kernel.org
 help / color / mirror / Atom feed
From: Holger Hans Peter Freyther <holger@freyther.de>
To: linux-sctp@vger.kernel.org
Subject: Re: Question regarding struct sctp_association
Date: Wed, 12 Jan 2011 14:35:26 +0000	[thread overview]
Message-ID: <4D2DBC2E.5000107@freyther.de> (raw)
In-Reply-To: <4D2AF2C3.8010306@freyther.de>

On 01/12/2011 02:00 AM, Wei Yongjun wrote:

>>                 /* Restart the AUTOCLOSE timer when sending data. */
>> -               if (sctp_state(asoc, ESTABLISHED) && asoc->autoclose) {
>> +               if (asoc && sctp_state(asoc, ESTABLISHED) && asoc->autoclose) {
>>                         timer = &asoc->timers[SCTP_EVENT_TIMEOUT_AUTOCLOSE];
>>                         timeout = asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE];
>>
>>
>> Can an OOTB packet contain data chunks that would make us go through this path?
> 
> AUTOCLOSE timer is only start when we have association, so this will
> not happen.

I am not sure, that is why I am asking. It appears that if there is any DATA
Chunk in the packet to send the code attempts to access 'asoc'. Can this code
path be ever triggered with an OOTB packet?

sorry if that question is too stupid

z.

      parent reply	other threads:[~2011-01-12 14:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10 11:51 Question regarding struct sctp_association Holger Hans Peter Freyther
2011-01-11  9:12 ` Wei Yongjun
2011-01-11 10:29 ` Holger Hans Peter Freyther
2011-01-12  1:00 ` Wei Yongjun
2011-01-12 14:35 ` Holger Hans Peter Freyther [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2DBC2E.5000107@freyther.de \
    --to=holger@freyther.de \
    --cc=linux-sctp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.