From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: [Qemu-devel] Re: [PATCH v2] add event queueing to USB HID
Date: Wed, 12 Jan 2011 17:27:16 +0100 [thread overview]
Message-ID: <4D2DD664.6090109@redhat.com> (raw)
In-Reply-To: <4D2DA63E.2030506@redhat.com>
Hi,
>>> I left the "changed" member in USBHIDState, rather than moving it
>>> to the keyboard, because it is useful to handle the idle period
>>> (in USB_TOKEN_IN) in a device-independent way. Without it the
>>> code became more messy.
>>
>> This leaves the same information recorded in the driver in two places
>> and is therefore IMO a bad idea. I still think the way I did this is
>> best: have a common helper function used by the keyboard and pointer
>> code to deal with the idle handling.
>
> I don't disagree, but I think this is better left for a separate patch.
Just use a queue for both pointer and keyboard -- problem solved ;)
Need a test case? Connect with vncviewer, press F8, pick "Send
Ctrl-Alt-Del" from the menu. Works with ps/2 keyboard. Doesn't work
with usb keyboard.
cheers,
Gerd
prev parent reply other threads:[~2011-01-12 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 12:19 [Qemu-devel] [PATCH v2] add event queueing to USB HID Paolo Bonzini
2011-01-12 12:34 ` [Qemu-devel] " Ian Jackson
2011-01-12 13:01 ` Paolo Bonzini
2011-01-12 13:05 ` Ian Jackson
2011-01-12 16:27 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2DD664.6090109@redhat.com \
--to=kraxel@redhat.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.