All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] rgmanager: Make clufindhostname -i	predictable
Date: Wed, 12 Jan 2011 18:07:49 +0100	[thread overview]
Message-ID: <4D2DDFE5.4000507@redhat.com> (raw)
In-Reply-To: <1294850820-10301-1-git-send-email-lhh@redhat.com>

ACK?ed.

Fabio

On 1/12/2011 5:47 PM, Lon Hohberger wrote:
> This is a clean cherry-pick into the RHEL6 branch
> 
> Resolves: rhbz#661881
> 
> Signed-off-by: Lon Hohberger <lhh@redhat.com>
> ---
>  rgmanager/src/utils/clufindhostname.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/rgmanager/src/utils/clufindhostname.c b/rgmanager/src/utils/clufindhostname.c
> index 42e1691..f8bf7fd 100644
> --- a/rgmanager/src/utils/clufindhostname.c
> +++ b/rgmanager/src/utils/clufindhostname.c
> @@ -24,7 +24,7 @@ main(int argc, char **argv)
>  	void *ptr;
>  	struct in_addr  addr4;
>  	struct in6_addr addr6;
> -	int opt, size, family;
> +	int opt, size, family, ret;
>  	char *sep;
>  
>  	if (argc != 3) {
> @@ -47,8 +47,10 @@ main(int argc, char **argv)
>  				size = sizeof(addr6);
>  			}
>  
> -			if (inet_pton(family, optarg, ptr) < 0) {
> -				perror("inet_pton");
> +			ret = inet_pton(family, optarg, ptr);
> +			if (ret <= 0) {
> +				if (ret < 0)
> +					perror("inet_pton");
>  				exit(2);
>  			}
>  



      reply	other threads:[~2011-01-12 17:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12 16:47 [Cluster-devel] [PATCH] rgmanager: Make clufindhostname -i predictable Lon Hohberger
2011-01-12 17:07 ` Fabio M. Di Nitto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2DDFE5.4000507@redhat.com \
    --to=fdinitto@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.