Re: [PATCH 1/5] sim: Cache flushing functions.

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

Hi Andrew,

On 01/10/2011 05:01 AM, Andrzej Zaborowski wrote:
> ---
>  src/sim.c   |   23 ++++++++++++++++++++
>  src/simfs.c |   68 ++++++++++++++++++++++++++++++++++++++++++++--------------
>  src/simfs.h |    5 ++++
>  3 files changed, 79 insertions(+), 17 deletions(-)
> 

So I applied this patch but...:

> +
> +static void sim_file_changed_flush(struct ofono_sim *sim, int id)
> +{
> +	int i, imgid;
> +
> +	if (id == SIM_EFIMG_FILEID)
> +		/* All cached images become invalid */
> +		sim_fs_image_cache_flush(sim->simfs);
> +	else if (sim->efimg)
> +		/*
> +		 * Data and CLUT for image instances stored in the changed
> +		 * file need to be re-read.
> +		 */
> +		for (i = sim->efimg_length / 9 - 1; i >= 0; i--) {
> +			imgid = (sim->efimg[i * 9 + 3] << 8) |
> +				sim->efimg[i * 9 + 4];
> +
> +			if (imgid == id)
> +				sim_fs_image_cache_flush_file(sim->simfs, i);
> +		}
> +
> +	sim_fs_cache_flush_file(sim->simfs, id);
> +}

This function seems extraneous to this patch.  I assumed that it was
meant to be included in patch 4 and I left it out.

Regards,
-Denis