From: Jiri Slaby <jirislaby@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
linux-fsdevel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
autofs@linux.kernel.org, npiggin@kernel.dk
Subject: Re: WARNING: at fs/dcache.c:1359 d_set_d_op [was: mmotm 2011-01-06-15-41 uploaded]
Date: Thu, 13 Jan 2011 10:57:24 +0100 [thread overview]
Message-ID: <4D2ECC84.8050406@gmail.com> (raw)
In-Reply-To: <4D2ECB56.4070802@gmail.com>
On 01/13/2011 10:52 AM, Jiri Slaby wrote:
> On 01/07/2011 12:41 AM, akpm@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to
>
> Hi, after some uptime and several suspend/resume cycles, I got:
> WARNING: at fs/dcache.c:1359 d_set_d_op+0x82/0xb0()
> Hardware name: To Be Filled By O.E.M.
> Modules linked in: dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
> Pid: 3474, comm: automount Tainted: G W 2.6.37-mm1_64+ #1344
> Call Trace:
> [<ffffffff8106bd2a>] ? warn_slowpath_common+0x7a/0xb0
> [<ffffffff8106bd75>] ? warn_slowpath_null+0x15/0x20
> [<ffffffff81125a32>] ? d_set_d_op+0x82/0xb0
> [<ffffffff8120d829>] ? autofs4_dir_mkdir+0x169/0x180
> [<ffffffff8111caa8>] ? vfs_mkdir+0x78/0xa0
> [<ffffffff811209e6>] ? sys_mkdirat+0xf6/0x110
> [<ffffffff81120a13>] ? sys_mkdir+0x13/0x20
> [<ffffffff81030dbb>] ? system_call_fastpath+0x16/0x1b
Note that even the second WARN was trigerred too:
WARNING: at fs/dcache.c:1365 d_set_d_op+0x9e/0xb0()
Hardware name: To Be Filled By O.E.M.
flags=00004000
Modules linked in: dvb_usb_af9015 tda18271 af9013 dvb_usb dvb_core
Pid: 3474, comm: automount Tainted: G W 2.6.37-mm1_64+ #1344
Call Trace:
[<ffffffff8106bd2a>] ? warn_slowpath_common+0x7a/0xb0
[<ffffffff8106be01>] ? warn_slowpath_fmt+0x41/0x50
[<ffffffff81125a4e>] ? d_set_d_op+0x9e/0xb0
[<ffffffff8120d829>] ? autofs4_dir_mkdir+0x169/0x180
[<ffffffff8111caa8>] ? vfs_mkdir+0x78/0xa0
[<ffffffff811209e6>] ? sys_mkdirat+0xf6/0x110
[<ffffffff81120a13>] ? sys_mkdir+0x13/0x20
[<ffffffff81030dbb>] ? system_call_fastpath+0x16/0x1b
My d_set_d_op looks like:
WARN_ON(dentry->d_op);
if (WARN(dentry->d_flags & (DCACHE_OP_HASH |
DCACHE_OP_COMPARE |
DCACHE_OP_REVALIDATE |
DCACHE_OP_REVALIDATE_RCU|
DCACHE_OP_DELETE),
"flags=%.8x", dentry->d_flags)) {
dentry->d_flags &= ~(DCACHE_OP_HASH | DCACHE_OP_COMPARE |
DCACHE_OP_REVALIDATE | DCACHE_OP_REVALIDATE_RCU |
DCACHE_OP_DELETE);
}
So DCACHE_OP_REVALIDATE remained set.
> I changed those BUG_ONs to WARN_ONs intentionally because I had problems
> with that previously -- I had to:
> dentry->d_flags &= ~(DCACHE_OP_HASH | DCACHE_OP_COMPARE |
> DCACHE_OP_REVALIDATE | DCACHE_OP_REVALIDATE_RCU |
> DCACHE_OP_DELETE);
>
> in d_set_d_op to not oops when calling NULLish op->d_delete later.
>
>
> The "Tainted: G W" is caused by:
> https://lkml.org/lkml/2011/1/10/63
regards,
--
js
next prev parent reply other threads:[~2011-01-13 9:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 23:41 mmotm 2011-01-06-15-41 uploaded akpm
2011-01-06 23:41 ` akpm
2011-01-07 17:18 ` mmotm 2011-01-06-15-41 uploaded (apple_bl) Randy Dunlap
2011-01-07 17:18 ` Randy Dunlap
2011-01-07 23:42 ` mmotm 2011-01-06-15-41 uploaded Stephen Rothwell
2011-01-10 18:04 ` [PATCH -mm] fix powerpc/sparc build Andrea Arcangeli
2011-01-10 18:04 ` Andrea Arcangeli
2011-01-10 10:19 ` WARNING: at kernel/workqueue.c [was: mmotm 2011-01-06-15-41 uploaded] Jiri Slaby
2011-01-10 16:31 ` Minchan Kim
2011-01-10 23:36 ` Tony Luck
2011-01-11 14:32 ` Tejun Heo
2011-01-12 1:34 ` Hillf Danton
2011-01-12 9:52 ` Tejun Heo
2011-01-10 14:37 ` qemu-kvm defunct due to THP " Jiri Slaby
2011-01-10 14:37 ` Jiri Slaby
2011-01-10 15:01 ` Andrea Arcangeli
2011-01-10 15:01 ` Andrea Arcangeli
2011-01-10 21:02 ` Jiri Slaby
2011-01-10 21:02 ` Jiri Slaby
2011-01-12 15:02 ` Andrea Arcangeli
2011-01-12 15:02 ` Andrea Arcangeli
2011-01-11 1:01 ` bnx2 card cannot be detected (WAS Re: mmotm 2011-01-06-15-41 uploaded) CAI Qian
2011-01-11 1:01 ` CAI Qian
2011-01-11 4:10 ` CAI Qian
2011-01-11 4:10 ` CAI Qian
2011-01-11 8:00 ` CAI Qian
2011-01-11 8:00 ` CAI Qian
2011-01-13 9:52 ` WARNING: at fs/dcache.c:1359 d_set_d_op [was: mmotm 2011-01-06-15-41 uploaded] Jiri Slaby
2011-01-13 9:57 ` Jiri Slaby [this message]
2011-01-13 10:54 ` Nick Piggin
2011-01-13 10:54 ` Nick Piggin
2011-01-13 15:33 ` Valdis.Kletnieks
2011-01-13 15:40 ` Jiri Slaby
2011-01-14 8:20 ` [autofs] " Ian Kent
2011-01-16 11:32 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2ECC84.8050406@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=autofs@linux.kernel.org \
--cc=hpa@zytor.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=npiggin@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.