From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42578 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdLbU-00075J-Kc
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 06:44:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1PdLbT-0004Nq-7c
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 06:44:32 -0500
Received: from mel.act-europe.fr ([194.98.77.210]:55711)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1PdLbT-0004NW-0x
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 06:44:31 -0500
Message-ID: <4D2EE59E.4020605@adacore.com>
Date: Thu, 13 Jan 2011 12:44:30 +0100
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Close Gdb stub connection in gdb_exit
References: <a8ac13b48a00dbb6e633204fbee460f2396f95a1.1294136554.git.chouteau@adacore.com>
	<4D2EC4E2.4080000@adacore.com>
	<20110113110156.GC7296@edde.se.axis.com>
In-Reply-To: <20110113110156.GC7296@edde.se.axis.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: qemu-devel@nongnu.org

On 01/13/2011 12:01 PM, Edgar E. Iglesias wrote:
> On Thu, Jan 13, 2011 at 10:24:50AM +0100, Fabien Chouteau wrote:
>> On 01/04/2011 11:27 AM, Fabien Chouteau wrote:
>>> On Windows, this is required to flush the remaining data in the IO stream,
>>> otherwise Gdb do not receive the last packet.
>>>
>>> Signed-off-by: Fabien Chouteau<chouteau@adacore.com>
>>> ---
>>>    gdbstub.c |    4 ++++
>>>    1 files changed, 4 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/gdbstub.c b/gdbstub.c
>>> index 0aa081b..dac3ce6 100644
>>> --- a/gdbstub.c
>>> +++ b/gdbstub.c
>>> @@ -2391,6 +2391,10 @@ void gdb_exit(CPUState *env, int code)
>>>
>>>      snprintf(buf, sizeof(buf), "W%02x", (uint8_t)code);
>>>      put_packet(s, buf);
>>> +
>>> +  if (s->chr) {
>>> +      qemu_chr_close(s->chr);
>>> +  }
>>>    }
>>>
>>>    #ifdef CONFIG_USER_ONLY
>>
>> Any comment on this patch?
>
> Yes, sorry for the delays. This patch breaks the linux-user build.

thanks,
I'll send new version in a minute.

-- 
Fabien Chouteau