Re: [PATCH 1/4] KVM: Fix x86_decode_insn() return code check

[Avi Kivity <avi@redhat.com>]

On 01/04/2011 03:14 PM, Avi Kivity wrote:
> x86_decode_insn() doesn't return X86EMUL_* values, it returns
> EMULATION_* codes.  Adjust the check.
>
> Signed-off-by: Avi Kivity<avi@redhat.com>
> ---
>   arch/x86/kvm/x86.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index fa708c9..b20499d 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -4391,7 +4391,7 @@ int x86_emulate_instruction(struct kvm_vcpu *vcpu,
>   		vcpu->arch.emulate_ctxt.perm_ok = false;
>
>   		r = x86_decode_insn(&vcpu->arch.emulate_ctxt, insn, insn_len);
> -		if (r == X86EMUL_PROPAGATE_FAULT)
> +		if (r != EMULATION_OK)
>   			goto done;
>
>   		trace_kvm_emulate_insn_start(vcpu);

Strangely, this patch causes a failure in Windows XP.  Dropping until 
submitter investigates and fixes.

-- 
error compiling committee.c: too many arguments to function