From: Milan Broz <mbroz@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Karel Zak <kzak@redhat.com>,
device-mapper development <dm-devel@redhat.com>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [dm-devel] linux-next - WARNING: at fs/block_dev.c:824 bd_link_disk_holder+0x92/0x1ac()
Date: Thu, 13 Jan 2011 15:25:46 +0100 [thread overview]
Message-ID: <4D2F0B6A.6010201@redhat.com> (raw)
In-Reply-To: <20110113141107.GI30719@htj.dyndns.org>
On 01/13/2011 03:11 PM, Tejun Heo wrote:
> So, as a general rule, when in doubt, just create an attribute. Let's
> refrain from custom symlinkery in sysfs, please. In this case too, a
> holder attribute containing strings like ext[3|4], md, dm or whatnot
> would have been _much_ simpler and actually more useful.
Maybe, but this was not invented in DM/MD camp:-)
Probably Kay or Greg can answer why it was done this way?
For DM it just added links to be proper user of it, see
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=f165921df46a977e3561f1bd9f13a348441486d1
Anyway, it is /sys/block - so it represents block devices.
If btrfs internally creates some virtual _block_ device for its pool, it should
present it here too with slaves/holders. If not, why it should create any links there?
Milan
next prev parent reply other threads:[~2011-01-13 14:25 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 17:34 linux-next - WARNING: at fs/block_dev.c:824 bd_link_disk_holder+0x92/0x1ac() Valdis.Kletnieks
2011-01-13 0:23 ` Milan Broz
2011-01-13 2:19 ` Jun'ichi Nomura
2011-01-13 11:06 ` Tejun Heo
2011-01-13 11:26 ` [dm-devel] " Milan Broz
2011-01-13 12:27 ` Karel Zak
2011-01-13 13:12 ` Tejun Heo
2011-01-13 13:26 ` Karel Zak
2011-01-13 13:37 ` Tejun Heo
2011-01-13 13:52 ` Tejun Heo
2011-01-13 13:58 ` Milan Broz
2011-01-13 14:11 ` Tejun Heo
2011-01-13 14:25 ` Milan Broz [this message]
2011-01-13 14:30 ` Tejun Heo
2011-01-13 14:43 ` Kay Sievers
2011-01-13 15:03 ` Milan Broz
2011-01-14 7:38 ` Jun'ichi Nomura
2011-01-13 15:59 ` Karel Zak
2011-01-13 15:59 ` [dm-devel] " Karel Zak
2011-01-13 16:10 ` Kay Sievers
2011-01-14 15:07 ` Karel Zak
2011-01-14 15:07 ` Karel Zak
2011-01-14 15:23 ` Kay Sievers
2011-01-14 15:23 ` Kay Sievers
2011-01-13 14:45 ` Theodore Tso
2011-01-13 20:18 ` NeilBrown
2011-01-13 20:41 ` Ted Ts'o
2011-01-14 16:20 ` Tejun Heo
2011-01-14 16:20 ` Tejun Heo
2011-01-14 16:20 ` Tejun Heo
2011-01-14 17:59 ` Ted Ts'o
2011-01-14 18:23 ` Tejun Heo
2011-01-14 18:23 ` [dm-devel] " Tejun Heo
2011-01-14 18:23 ` Tejun Heo
2011-01-14 18:23 ` Tejun Heo
2011-01-13 14:49 ` Milan Broz
2011-01-14 16:35 ` Tejun Heo
2011-01-13 17:21 ` [PATCH] block: restore multiple bd_link_disk_holder() support Tejun Heo
2011-01-13 18:42 ` Milan Broz
2011-01-14 7:31 ` Jun'ichi Nomura
2011-01-14 16:10 ` [PATCH UPDATED] " Tejun Heo
2011-01-14 16:10 ` Tejun Heo
2011-01-14 21:09 ` Milan Broz
2011-01-17 0:18 ` Jun'ichi Nomura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2F0B6A.6010201@redhat.com \
--to=mbroz@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=kay.sievers@vrfy.org \
--cc=kzak@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.