All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/1] BMP: Add support for 32bpp video frame buffer
Date: Thu, 13 Jan 2011 16:14:45 +0100	[thread overview]
Message-ID: <4D2F16E5.1020502@free-electrons.com> (raw)
In-Reply-To: <4D23313B.9040002@free-electrons.com>

On 01/04/2011 03:39 PM, Gregory CLEMENT wrote:
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  commands/bmp.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/commands/bmp.c b/commands/bmp.c
> index 5bac031..644a977 100644
> --- a/commands/bmp.c
> +++ b/commands/bmp.c
> @@ -25,6 +25,7 @@ static inline void set_pixel(struct fb_info *info, void *adr, int r, int g, int
>  		*(u16 *)adr = px;
>  		break;
>  	case 32:
> +		*(u32 *)adr = px;
>  		break;
>  	}
>  }
Any comments for this patch?

It seems pretty trivial and it works at least for me.
But if I missed something, let me know.

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-01-13 15:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04 14:39 [PATCH 1/1] BMP: Add support for 32bpp video frame buffer Gregory CLEMENT
2011-01-13 15:14 ` Gregory CLEMENT [this message]
2011-01-14  9:45   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2F16E5.1020502@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.