From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: Last call for forgotten tools patches for Xen 4.1 Date: Thu, 13 Jan 2011 08:48:54 -0700 Message-ID: <4D2F1EE6.8040109@novell.com> References: <19750.386.258317.29710@mariner.uk.xensource.com> <4D2E3417.1020208@novell.com> <19758.58723.681181.302589@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19758.58723.681181.302589@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Chun Yan Liu Cc: "xen-devel@lists.xensource.com" , Ian Jackson List-Id: xen-devel@lists.xenproject.org Ian Jackson wrote: > Jim Fehlig writes ("Re: [Xen-devel] Last call for forgotten tools patches for Xen 4.1"): > >> Sorry for the delay, but I just noticed this tools patch submitted by >> Chun Yan back in November >> >> http://lists.xensource.com/archives/html/xen-devel/2010-11/msg01559.html >> > > Thanks. I replied to that but there was no updated patch. > Opps, I thought Chunyan had sent an updated patch but perhaps have confused this with her qemu keysym patches. > Now that I look at the patch again I see some other problems: > * It closes the fd onto the file after locking it with flock (!) > * On success it unlinks the lock file after locking it (!!) > * The error return value is wrong (or perhaps it was wrong before). > Err, right. And there was no follow-up as I assumed. Chunyan, can you address Ian's comments and submit an updated patch? Thanks, Jim