From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH] xend: drbd improvements Date: Thu, 13 Jan 2011 08:59:04 -0700 Message-ID: <4D2F2148.6060504@novell.com> References: <19673.37479.133902.499115@mariner.uk.xensource.com> <4CD9C962.4030701@novell.com> <4CDADB46.7020100@novell.com> <4D0AB298.4080202@novell.com> <19748.65417.734677.848857@mariner.uk.xensource.com> <4D2B96C7.4050508@novell.com> <4D2E73A4.6050203@novell.com> <19758.58834.718990.325579@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19758.58834.718990.325579@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Ian Jackson wrote: > Jim Fehlig writes ("Re: [Xen-devel] [PATCH] xend: drbd improvements"): > >> Have you had a chance to test my suggestion above (reverting c/s 19444 >> and using the xend patch we have in SuSE)? It has been working well for >> us, but another "Tested-by:" may convince upstream to take these changes >> as well. Perhaps it is too late for 4.1 as we're at RC2 already. >> > > I'd love to have another test report. Shriram reported that he successfully tested these changes. > I didn't apply these patches > because it wasn't clear to me exactly what the proposed changes were > and, as you say, that they had been sufficiently tested. > The revert of c/s 19444 simply removes more 'drbd' cruft from xend internals. As for my xend patch, is the commit message that vague? ------------------------- xend: improve psudeo-bootloader support for external block scripts Userspace tools support external block scripts (e.g. block-drbd provided by drbd project). The psuedo-bootloader setup code in xend has a few limitations wrt external block scripts, which this patch addresses. blkif.py: parse_uname() utility function should be able to parse a disk specifier understood by the rest of the tools. XendDomainInfo.py: Block devices using external block scripts must be attached to dom0 before running the psuedo-bootloader. ------------------------- I can improve it if need be. Regards, Jim