From: Patrick McHardy <kaber@trash.net>
To: Juliusz Chroboczek <jch@pps.jussieu.fr>
Cc: netdev <netdev@vger.kernel.org>,
Jesper Dangaard Brouer <hawk@diku.dk>,
David Miller <davem@davemloft.net>
Subject: Re: sch_sfb [was: net_sched: mark packet staying on queue too long]
Date: Thu, 13 Jan 2011 19:59:15 +0100 [thread overview]
Message-ID: <4D2F4B83.6060001@trash.net> (raw)
In-Reply-To: <87bp3kg58i.fsf_-_@trurl.pps.jussieu.fr>
Am 13.01.2011 17:04, schrieb Juliusz Chroboczek:
>>> Have you looked at the SFB (Stochastic Fair Blue) implementation by
>>> Juliusz Chroboczek?
>
>>> http://www.pps.jussieu.fr/~jch/software/sfb/
>
>> I had a closer look at this some time ago and noticed a couple of bugs
>> (f.i. double buffering might be enabled or disabled or the buffers
>> switched while a packet is queued, so on dequeue the wrong buffer will
>> have its queue length decremented) and also found the hashing quite
>> inefficient,
>
> And you never found the time to drop me a mail on the subject?
Well, I just looked at it out of interest after already having started
my own version. Also I was riding the train without possibility of
communication :)
>> so I've implemented my own version.
>
> I see.
I took a lot of ideas from your version, and this is also mentioned
in my version. It just seemed easier to start from scratch than to
fully analyze your version and base it on the original paper.
Since to my knowledge you've never attempted an upstream merge this
also seemed like the more polite way. No impoliteness intended.
next prev parent reply other threads:[~2011-01-13 18:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 14:35 [PATCH net-2.6] net_sched: always clone skbs Changli Gao
2010-12-20 14:37 ` Eric Dumazet
2010-12-20 18:27 ` David Miller
2010-12-20 23:20 ` Jarek Poplawski
2010-12-20 23:28 ` Eric Dumazet
2010-12-20 23:52 ` Jarek Poplawski
2010-12-21 13:52 ` jamal
2010-12-21 14:17 ` Changli Gao
2010-12-21 22:37 ` Jarek Poplawski
2010-12-23 13:35 ` jamal
2010-12-23 23:04 ` Jarek Poplawski
2011-01-02 21:27 ` [RFC] net_sched: mark packet staying on queue too long Eric Dumazet
2011-01-03 13:52 ` jamal
2011-01-03 14:02 ` Eric Dumazet
2011-01-03 15:02 ` jamal
2011-01-03 18:11 ` [PATCH] sch_red: report backlog information Eric Dumazet
2011-01-03 20:13 ` David Miller
2011-01-03 17:58 ` [RFC] net_sched: mark packet staying on queue too long Stephen Hemminger
2011-01-04 14:19 ` Jesper Dangaard Brouer
2011-01-04 15:02 ` Eric Dumazet
2011-01-04 16:05 ` Stephen Hemminger
2011-01-04 18:20 ` Eric Dumazet
2011-01-04 18:29 ` Eric Dumazet
2011-01-13 11:50 ` Patrick McHardy
2011-01-13 15:54 ` Eric Dumazet
2011-01-13 16:04 ` sch_sfb [was: net_sched: mark packet staying on queue too long] Juliusz Chroboczek
2011-01-13 18:59 ` Patrick McHardy [this message]
2011-01-14 0:59 ` sch_sfb Juliusz Chroboczek
2011-01-14 1:39 ` sch_sfb Patrick McHardy
2011-01-14 13:34 ` sch_sfb Juliusz Chroboczek
2011-01-14 13:37 ` sch_sfb Patrick McHardy
2011-01-14 15:09 ` sch_sfb Eric Dumazet
2011-01-14 21:06 ` sch_sfb Jarek Poplawski
2010-12-21 0:21 ` [PATCH net-2.6] net_sched: always clone skbs Changli Gao
2010-12-21 3:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2F4B83.6060001@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=hawk@diku.dk \
--cc=jch@pps.jussieu.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.