Re: [Qemu-devel] paravirtual mouse/tablet

[Avi Kivity <avi@redhat.com>]

On 01/13/2011 07:19 PM, Gerd Hoffmann wrote:
> On 01/13/11 17:18, Avi Kivity wrote:
>> On 01/13/2011 12:19 PM, Gerd Hoffmann wrote:
>>> Hi,
>>>
>>> Just throwing a quick writeup into the ring to kickstart the design
>>> discussion ;)
>>>
>>>
>>> typedef struct qemu_pvtablet_message {
>>> uint32_t size; /* whole message size */
>>> uint32_t type; /* qemu_pvtablet_type */
>>> uint64_t tv_secs;
>>> uint64_t tv_usecs;
>>
>> time relative to what base?
>
> Guess that needs to be refined ;)
>
> Just something relative (if available) should good enougth.  The 
> intended purpose is being able to figure how much time passed between 
> two events, so one can figure whenever two mouse clicks should be 
> considered a double-click or not.  Ideally the timestamps from the 
> original mouse event in the vnc/spice client would be passed all the 
> way through to the guest.  Didn't check the protocols whenever they 
> actually support that, but I think we should have this in the protocol 
> even if they don't ...

Ok.  We should then specify that the base is arbitrary (and get rid of 
tv_secs - 2^64 usecs is half a million years, which should be sufficient 
time to get a fully threaded qemu.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.