[PATCH] e2fsprogs: change mode of non-links only

[PATCH] e2fsprogs: change mode of non-links only

[Enrico Scholz]

From: Enrico Scholz <enrico.scholz@informatik.tu-chemnitz.de>

When building as a dedicated user, compilation fails else in a way like

| + cd ..../e2fsprogs-1.41.12-r27/e2fsprogs-1.41.12
| + do_compile
| + find ./ -print
| + xargs chmod u=rwX
| chmod: changing permissions of `./patches/llseek-uclibc.patch': Operation not permitted
| ERROR: Function do_compile failed

Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
---
 recipes/e2fsprogs/e2fsprogs.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/e2fsprogs/e2fsprogs.inc b/recipes/e2fsprogs/e2fsprogs.inc
index 34b9950..bdb4bbb 100644
--- a/recipes/e2fsprogs/e2fsprogs.inc
+++ b/recipes/e2fsprogs/e2fsprogs.inc
@@ -23,7 +23,7 @@ EXTRA_OECONF = "${@['','--disable-tls'][bb.data.getVar('ARM_ABI', d, 1) == 'oabi
 PARALLEL_MAKE = ""
 
 do_compile_prepend () {
-	find ./ -print|xargs chmod u=rwX
+	find ./ ! -type l -print|xargs chmod u=rwX
 	( cd util; ${BUILD_CC} subst.c -o subst )
 }
 
-- 
1.7.3.4

Re: [PATCH] e2fsprogs: change mode of non-links only

[Khem Raj]

On 1/13/2011 6:21 AM, Enrico Scholz wrote:
> From: Enrico Scholz<enrico.scholz@informatik.tu-chemnitz.de>
>
> When building as a dedicated user, compilation fails else in a way like
>
> | + cd ..../e2fsprogs-1.41.12-r27/e2fsprogs-1.41.12
> | + do_compile
> | + find ./ -print
> | + xargs chmod u=rwX
> | chmod: changing permissions of `./patches/llseek-uclibc.patch': Operation not permitted
> | ERROR: Function do_compile failed


alternatively you can exclude patches directory from feeding into chmod

>
> Signed-off-by: Enrico Scholz<enrico.scholz@sigma-chemnitz.de>
> ---
>   recipes/e2fsprogs/e2fsprogs.inc |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/e2fsprogs/e2fsprogs.inc b/recipes/e2fsprogs/e2fsprogs.inc
> index 34b9950..bdb4bbb 100644
> --- a/recipes/e2fsprogs/e2fsprogs.inc
> +++ b/recipes/e2fsprogs/e2fsprogs.inc
> @@ -23,7 +23,7 @@ EXTRA_OECONF = "${@['','--disable-tls'][bb.data.getVar('ARM_ABI', d, 1) == 'oabi
>   PARALLEL_MAKE = ""
>
>   do_compile_prepend () {
> -	find ./ -print|xargs chmod u=rwX
> +	find ./ ! -type l -print|xargs chmod u=rwX
>   	( cd util; ${BUILD_CC} subst.c -o subst )
>   }
>

Re: [PATCH] e2fsprogs: change mode of non-links only

[Enrico Scholz]

Khem Raj <raj.khem@gmail.com> writes:

> alternatively you can exclude patches directory from feeding into
> chmod

I do not think that excluding a single, implementation specific directory
is a good idea. When this or a future package contains symlinks to outside
the buildroot, problem would be triggered again.

Doing blindly 'find | xargs chmod' is just wrong...

I will submit a new patch which executes 'chmod -R u=rwx .' (this does
not dereference symlinks) instead of using the find pipe.


>> -	find ./ -print|xargs chmod u=rwX
>> +	find ./ ! -type l -print|xargs chmod u=rwX



Enrico