All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] zlib: substitute sharedlibdir
Date: Thu, 13 Jan 2011 19:24:35 -0800	[thread overview]
Message-ID: <4D2FC1F3.20504@gmail.com> (raw)
In-Reply-To: <1294928952-25833-1-git-send-email-enrico.scholz@sigma-chemnitz.de>

On 1/13/2011 6:29 AM, Enrico Scholz wrote:
> From: Enrico Scholz<enrico.scholz@informatik.tu-chemnitz.de>
>
> @sharedlibdir@ is not substituted so that linkerflags in zlib.pc expand to
> "... -L@sharedlibdir@" which breaks e.g. glib builds.
>


I think zlib has --sharedlibdir configure option since 1.2.4.4+
so you could try to use it instead of patching

> Signed-off-by: Enrico Scholz<enrico.scholz@sigma-chemnitz.de>
> ---
>   recipes/zlib/zlib-1.2.5/0001-autotools.patch |    4 +++-
>   recipes/zlib/zlib_1.2.5.bb                   |    2 +-
>   2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/recipes/zlib/zlib-1.2.5/0001-autotools.patch b/recipes/zlib/zlib-1.2.5/0001-autotools.patch
> index 6642860..f5c50f1 100644
> --- a/recipes/zlib/zlib-1.2.5/0001-autotools.patch
> +++ b/recipes/zlib/zlib-1.2.5/0001-autotools.patch
> @@ -33,7 +33,7 @@ new file mode 100644
>   index 0000000..177c89a
>   --- /dev/null
>   +++ b/configure.ac
> -@@ -0,0 +1,17 @@
> +@@ -0,0 +1,19 @@
>   +AC_INIT(zlib,1.2.5)
>   +AC_CONFIG_SRCDIR(adler32.c)
>   +AM_INIT_AUTOMAKE(zlibs,1.2.5)
> @@ -45,6 +45,8 @@ index 0000000..177c89a
>   +
>   +AC_HEADER_STDC
>   +
> ++AC_SUBST(sharedlibdir,$libdir)
> ++
>   +AC_CONFIG_FILES([
>   +Makefile
>   +zlib.pc
> diff --git a/recipes/zlib/zlib_1.2.5.bb b/recipes/zlib/zlib_1.2.5.bb
> index 34419f0..1f51404 100644
> --- a/recipes/zlib/zlib_1.2.5.bb
> +++ b/recipes/zlib/zlib_1.2.5.bb
> @@ -1,6 +1,6 @@
>   include zlib.inc
>
> -PR = "${INC_PR}.0"
> +PR = "${INC_PR}.1"
>
>   SRC_URI += "file://0001-autotools.patch "
>




  reply	other threads:[~2011-01-14  3:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-13 14:29 [PATCH] zlib: substitute sharedlibdir Enrico Scholz
2011-01-14  3:24 ` Khem Raj [this message]
2011-01-14  9:55   ` Enrico Scholz
2011-01-14 20:10     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2FC1F3.20504@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.