From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4D2FDD62.4040106@st.com> Date: Fri, 14 Jan 2011 10:51:38 +0530 From: viresh kumar MIME-Version: 1.0 To: "linux-mtd@lists.infradead.org" , "dwmw2@infradead.org" , "linus.walleij@stericsson.com" Subject: Re: [PATCH V3 25/63 resend] Newly erased page read workaround References: <6187de0568d1ea8a6aeb6c3ca54ac6684bee9973.1292833228.git.viresh.kumar@st.com> In-Reply-To: <6187de0568d1ea8a6aeb6c3ca54ac6684bee9973.1292833228.git.viresh.kumar@st.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Rajeev KUMAR , Armando VISCONTI , Vipin KUMAR , Shiraz HASHIM , Amit VIRDI , Vipul Kumar SAMAR , Deepak SIKRI , "linux-arm-kernel@lists.infradead.org" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/20/2010 02:49 PM, Viresh KUMAR wrote: > From: Vipin Kumar > > A newly erased page contains ff in data as well as spare area. While reading an > erased page, the read out ecc from spare area does not match the ecc generated > by fsmc ecc hardware accelarator. This is because ecc of data ff ff is not ff > ff. This leads to errors when jffs2 fs erases and reads back the pages to > ensure consistency. > > This patch adds a software workaround to ensure that the ecc check is not > performed for erased pages. An erased page is checked by checking data as ff ff. David, Does this patch looks fine to you?? -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@st.com (viresh kumar) Date: Fri, 14 Jan 2011 10:51:38 +0530 Subject: [PATCH V3 25/63 resend] Newly erased page read workaround In-Reply-To: <6187de0568d1ea8a6aeb6c3ca54ac6684bee9973.1292833228.git.viresh.kumar@st.com> References: <6187de0568d1ea8a6aeb6c3ca54ac6684bee9973.1292833228.git.viresh.kumar@st.com> Message-ID: <4D2FDD62.4040106@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/20/2010 02:49 PM, Viresh KUMAR wrote: > From: Vipin Kumar > > A newly erased page contains ff in data as well as spare area. While reading an > erased page, the read out ecc from spare area does not match the ecc generated > by fsmc ecc hardware accelarator. This is because ecc of data ff ff is not ff > ff. This leads to errors when jffs2 fs erases and reads back the pages to > ensure consistency. > > This patch adds a software workaround to ensure that the ecc check is not > performed for erased pages. An erased page is checked by checking data as ff ff. David, Does this patch looks fine to you?? -- viresh