From: Holger Hans Peter Freyther <holger@freyther.de>
To: linux-sctp@vger.kernel.org
Subject: Re: [PATCH][RFC] Allow to use adler32 for SCTP
Date: Fri, 14 Jan 2011 09:00:09 +0000 [thread overview]
Message-ID: <4D301099.20707@freyther.de> (raw)
In-Reply-To: <4D2DC00A.8030208@freyther.de>
On 01/14/2011 02:25 AM, Wei Yongjun wrote:
>
> decode both checksums by default will cause performance lost.
> Why not change this to kernel config, and disable it by default since
> most people do not need this?
Well, by default I am only checking the CRC32 checksum and have a test and a
branch for a global variable. So the question is what is the impact of the
extra load of the global variable?
Do you have a benchmark in mind? Something as simple as one connection and
sending messages between two machines? Or should I guard this whole config
with a kernel config right away?
>
> Other question: why not just update your box which only support
> adler32 to support new crc32 checksums? Linux and Freebsd etc.
> do not using adler32, but using crc32.
>
I wish I could, the machine is on the edge of the network and not in my control.
next prev parent reply other threads:[~2011-01-14 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 14:51 [PATCH][RFC] Allow to use adler32 for SCTP Holger Hans Peter Freyther
2011-01-14 1:25 ` Wei Yongjun
2011-01-14 9:00 ` Holger Hans Peter Freyther [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-01-09 21:36 Holger Hans Peter Freyther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D301099.20707@freyther.de \
--to=holger@freyther.de \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.