error in 2.6.37-git10

error in 2.6.37-git10

[Piotr Hosowicz]

Hello,

Build failed here:

   CC [M]  fs/ecryptfs/main.o
fs/ecryptfs/main.c:144: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or 
‘__attribute__’ before ‘*’ token
fs/ecryptfs/main.c: In function ‘ecryptfs_interpose’:
fs/ecryptfs/main.c:204: error: implicit declaration of function 
‘ecryptfs_get_inode’
fs/ecryptfs/main.c:204: warning: initialization makes pointer from 
integer without a cast
fs/ecryptfs/main.c:206: error: expected ‘)’ before ‘return’
fs/ecryptfs/main.c:212: error: expected expression before ‘}’ token
fs/ecryptfs/main.c: In function ‘ecryptfs_mount’:
fs/ecryptfs/main.c:569: warning: assignment makes pointer from integer 
without a cast

Regards,

Piotr Hosowicz

-- 
Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach:
- Gdzie odbywały się lądowania Aliantów (D-Day)?
- Pearl Harbour?
NP: Patrick O'Hearn - Beautiful World
NB: 2.6.37-20110113-1411-pztidm+

Re: error in 2.6.37-git10

[Felipe Balbi]

On Fri, Jan 14, 2011 at 10:51:33AM +0100, Piotr Hosowicz wrote:
> Hello,
> 
> Build failed here:
> 
>   CC [M]  fs/ecryptfs/main.o
> fs/ecryptfs/main.c:144: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or
> ‘__attribute__’ before ‘*’ token
> fs/ecryptfs/main.c: In function ‘ecryptfs_interpose’:
> fs/ecryptfs/main.c:204: error: implicit declaration of function
> ‘ecryptfs_get_inode’
> fs/ecryptfs/main.c:204: warning: initialization makes pointer from
> integer without a cast
> fs/ecryptfs/main.c:206: error: expected ‘)’ before ‘return’
> fs/ecryptfs/main.c:212: error: expected expression before ‘}’ token
> fs/ecryptfs/main.c: In function ‘ecryptfs_mount’:
> fs/ecryptfs/main.c:569: warning: assignment makes pointer from
> integer without a cast

Could you check whether this is enough?

diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
index d3b28ab..d2e71a2 100644
--- a/fs/ecryptfs/main.c
+++ b/fs/ecryptfs/main.c
@@ -34,6 +34,7 @@
 #include <linux/pagemap.h>
 #include <linux/key.h>
 #include <linux/parser.h>
+#include <linux/fs.h>
 #include <linux/fs_stack.h>
 #include <linux/slab.h>
 #include "ecryptfs_kernel.h"

-- 
balbi

Re: error in 2.6.37-git10

[Piotr Hosowicz]

On 14.01.2011 10:57, Felipe Balbi wrote:
> On Fri, Jan 14, 2011 at 10:51:33AM +0100, Piotr Hosowicz wrote:
>> Hello,
>>
>> Build failed here:
>>
>>    CC [M]  fs/ecryptfs/main.o
>> fs/ecryptfs/main.c:144: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or
>> ‘__attribute__’ before ‘*’ token
>> fs/ecryptfs/main.c: In function ‘ecryptfs_interpose’:
>> fs/ecryptfs/main.c:204: error: implicit declaration of function
>> ‘ecryptfs_get_inode’
>> fs/ecryptfs/main.c:204: warning: initialization makes pointer from
>> integer without a cast
>> fs/ecryptfs/main.c:206: error: expected ‘)’ before ‘return’
>> fs/ecryptfs/main.c:212: error: expected expression before ‘}’ token
>> fs/ecryptfs/main.c: In function ‘ecryptfs_mount’:
>> fs/ecryptfs/main.c:569: warning: assignment makes pointer from
>> integer without a cast
>
> Could you check whether this is enough?

I am building now with this option disabled, maybe I'll have time to 
test again.

Regards,

Piotr Hosowicz

-- 
"Chcemy waszego dobra!" - powiedział lider
socjaldemokratów. Zaniepokojeni obywatele
zaczeli ukrywać swoje dobra w bezpiecznych
miejscach.
NP: Patrick O'Hearn - Approaching Summit
NB: 2.6.37-20110113-1411-pztidm+

Re: error in 2.6.37-git10

[Felipe Balbi]

On Fri, Jan 14, 2011 at 11:07:35AM +0100, Piotr Hosowicz wrote:
> On 14.01.2011 10:57, Felipe Balbi wrote:
> >On Fri, Jan 14, 2011 at 10:51:33AM +0100, Piotr Hosowicz wrote:
> >>Hello,
> >>
> >>Build failed here:
> >>
> >>   CC [M]  fs/ecryptfs/main.o
> >>fs/ecryptfs/main.c:144: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or
> >>‘__attribute__’ before ‘*’ token
> >>fs/ecryptfs/main.c: In function ‘ecryptfs_interpose’:
> >>fs/ecryptfs/main.c:204: error: implicit declaration of function
> >>‘ecryptfs_get_inode’
> >>fs/ecryptfs/main.c:204: warning: initialization makes pointer from
> >>integer without a cast
> >>fs/ecryptfs/main.c:206: error: expected ‘)’ before ‘return’
> >>fs/ecryptfs/main.c:212: error: expected expression before ‘}’ token
> >>fs/ecryptfs/main.c: In function ‘ecryptfs_mount’:
> >>fs/ecryptfs/main.c:569: warning: assignment makes pointer from
> >>integer without a cast
> >
> >Could you check whether this is enough?
> 
> I am building now with this option disabled, maybe I'll have time to
> test again.

I just did. Compiled only that module with that header added. Built
cleanly.

Sent a patch and Cced you too.

-- 
balbi

Re: error in 2.6.37-git10

[Piotr Hosowicz]

On 14.01.2011 11:08, Felipe Balbi wrote:
> On Fri, Jan 14, 2011 at 11:07:35AM +0100, Piotr Hosowicz wrote:
>> On 14.01.2011 10:57, Felipe Balbi wrote:
>>> On Fri, Jan 14, 2011 at 10:51:33AM +0100, Piotr Hosowicz wrote:
>>>> Hello,
>>>>
>>>> Build failed here:
>>>>
>>>>    CC [M]  fs/ecryptfs/main.o
>>>> fs/ecryptfs/main.c:144: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or
>>>> ‘__attribute__’ before ‘*’ token
>>>> fs/ecryptfs/main.c: In function ‘ecryptfs_interpose’:
>>>> fs/ecryptfs/main.c:204: error: implicit declaration of function
>>>> ‘ecryptfs_get_inode’
>>>> fs/ecryptfs/main.c:204: warning: initialization makes pointer from
>>>> integer without a cast
>>>> fs/ecryptfs/main.c:206: error: expected ‘)’ before ‘return’
>>>> fs/ecryptfs/main.c:212: error: expected expression before ‘}’ token
>>>> fs/ecryptfs/main.c: In function ‘ecryptfs_mount’:
>>>> fs/ecryptfs/main.c:569: warning: assignment makes pointer from
>>>> integer without a cast
>>>
>>> Could you check whether this is enough?
>>
>> I am building now with this option disabled, maybe I'll have time to
>> test again.
>
> I just did. Compiled only that module with that header added. Built
> cleanly.

I corrected and am building again. Hope this helps.

Regards,

Piotr Hosowicz

-- 
W korytarzach kremlowskich Breżniew spotyka Susłowa. Susłow pyta:
- Leonid, wiesz, że jeden but masz żółty, a drugi czarny?
- Wiem, Misza, chciałem nawet zmienić, ale w domu mam to samo,
   jeden żółty i jeden czarny.
NP: Patrick O'Hearn - An Evening Sky
NB: 2.6.37-20110113-1411-pztidm+

Re: error in 2.6.37-git10

[Piotr Hosowicz]

On 14.01.2011 11:13, Piotr Hosowicz wrote:
> On 14.01.2011 11:08, Felipe Balbi wrote:
>> On Fri, Jan 14, 2011 at 11:07:35AM +0100, Piotr Hosowicz wrote:
>>> On 14.01.2011 10:57, Felipe Balbi wrote:
>>>> On Fri, Jan 14, 2011 at 10:51:33AM +0100, Piotr Hosowicz wrote:
>>>>> Hello,
>>>>>
>>>>> Build failed here:
>>>>>
>>>>> CC [M] fs/ecryptfs/main.o
>>>>> fs/ecryptfs/main.c:144: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or
>>>>> ‘__attribute__’ before ‘*’ token
>>>>> fs/ecryptfs/main.c: In function ‘ecryptfs_interpose’:
>>>>> fs/ecryptfs/main.c:204: error: implicit declaration of function
>>>>> ‘ecryptfs_get_inode’
>>>>> fs/ecryptfs/main.c:204: warning: initialization makes pointer from
>>>>> integer without a cast
>>>>> fs/ecryptfs/main.c:206: error: expected ‘)’ before ‘return’
>>>>> fs/ecryptfs/main.c:212: error: expected expression before ‘}’ token
>>>>> fs/ecryptfs/main.c: In function ‘ecryptfs_mount’:
>>>>> fs/ecryptfs/main.c:569: warning: assignment makes pointer from
>>>>> integer without a cast
>>>>
>>>> Could you check whether this is enough?
>>>
>>> I am building now with this option disabled, maybe I'll have time to
>>> test again.
>>
>> I just did. Compiled only that module with that header added. Built
>> cleanly.
>
> I corrected and am building again. Hope this helps.

I don't know why but it failed again. I disabled and am building again.

Regards,

Piotr Hosowicz

-- 
Janusz Korwin-Mikke:
"ZUS z pewnością jest instytucją przestępczą,
ale nie można nazwać jej zorganizowaną."
NP: Patrick O'Hearn - Approaching Summit
NB: 2.6.37-20110113-1411-pztidm+

Re: error in 2.6.37-git10

[Felipe Balbi]

Hi,

On Fri, Jan 14, 2011 at 11:53:02AM +0100, Piotr Hosowicz wrote:
> >I corrected and am building again. Hope this helps.
> 
> I don't know why but it failed again. I disabled and am building again.

for me it builds ok:

  CC [M]  fs/ecryptfs/dentry.o
  CC [M]  fs/ecryptfs/file.o
  CC [M]  fs/ecryptfs/inode.o
  CC [M]  fs/ecryptfs/main.o
  CC [M]  fs/ecryptfs/super.o
  CC [M]  fs/ecryptfs/mmap.o
  CC [M]  fs/ecryptfs/read_write.o
  CC [M]  fs/ecryptfs/crypto.o
  CC [M]  fs/ecryptfs/keystore.o
  CC [M]  fs/ecryptfs/messaging.o
  CC [M]  fs/ecryptfs/miscdev.o
  CC [M]  fs/ecryptfs/kthread.o
  CC [M]  fs/ecryptfs/debug.o
  LD [M]  fs/ecryptfs/ecryptfs.o

weird.

-- 
balbi

Re: error in 2.6.37-git10

[Eric Dumazet]

Le vendredi 14 janvier 2011 à 12:56 +0200, Felipe Balbi a écrit :
> Hi,
> 
> On Fri, Jan 14, 2011 at 11:53:02AM +0100, Piotr Hosowicz wrote:
> > >I corrected and am building again. Hope this helps.
> > 
> > I don't know why but it failed again. I disabled and am building again.
> 
> for me it builds ok:
> 
>   CC [M]  fs/ecryptfs/dentry.o
>   CC [M]  fs/ecryptfs/file.o
>   CC [M]  fs/ecryptfs/inode.o
>   CC [M]  fs/ecryptfs/main.o
>   CC [M]  fs/ecryptfs/super.o
>   CC [M]  fs/ecryptfs/mmap.o
>   CC [M]  fs/ecryptfs/read_write.o
>   CC [M]  fs/ecryptfs/crypto.o
>   CC [M]  fs/ecryptfs/keystore.o
>   CC [M]  fs/ecryptfs/messaging.o
>   CC [M]  fs/ecryptfs/miscdev.o
>   CC [M]  fs/ecryptfs/kthread.o
>   CC [M]  fs/ecryptfs/debug.o
>   LD [M]  fs/ecryptfs/ecryptfs.o
> 
> weird.
> 

This is because it was fixed meanwhile

commit 6254b32b5791e47ba1c679d023f26985fa34755a
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu Jan 13 17:19:38 2011 -0800

    ecryptfs: fix broken build
    
    Stephen Rothwell reports that the vfs merge broke the build of ecryptfs.
    The breakage comes from commit 66cb76666d69 ("sanitize ecryptfs
    ->mount()") which was obviously not even build tested. Tssk, tssk, Al.
    
    This is the minimal build fixup for the situation, although I don't have
    a filesystem to actually test it with.
    
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>