[PATCH] kernel/async.c: fixing compilation warnings

[PATCH] kernel/async.c: fixing compilation warnings

[Viresh Kumar]

This patch fixes following compilation warnings:
270:10: warning: ‘starttime.tv64’ may be used uninitialized in this function
122:10: warning: ‘calltime.tv64’ may be used uninitialized in this function

Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
---
 kernel/async.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/async.c b/kernel/async.c
index cd9dbb9..9c06931 100644
--- a/kernel/async.c
+++ b/kernel/async.c
@@ -119,7 +119,7 @@ static void async_run_entry_fn(struct work_struct *work)
 	struct async_entry *entry =
 		container_of(work, struct async_entry, work);
 	unsigned long flags;
-	ktime_t calltime, delta, rettime;
+	ktime_t calltime = {0}, delta, rettime;
 
 	/* 1) move self to the running queue */
 	spin_lock_irqsave(&async_lock, flags);
@@ -267,7 +267,7 @@ EXPORT_SYMBOL_GPL(async_synchronize_full_domain);
 void async_synchronize_cookie_domain(async_cookie_t cookie,
 				     struct list_head *running)
 {
-	ktime_t starttime, delta, endtime;
+	ktime_t starttime = {0}, delta, endtime;
 
 	if (initcall_debug && system_state == SYSTEM_BOOTING) {
 		printk("async_waiting @ %i\n", task_pid_nr(current));
-- 
1.7.2.2

Re: [PATCH] kernel/async.c: fixing compilation warnings

[Jack Stone]

"Viresh Kumar" <viresh.kumar@st.com> wrote:

>This patch fixes following compilation warnings:
>270:10: warning: ‘starttime.tv64’ may be used uninitialized in this
>function
>122:10: warning: ‘calltime.tv64’ may be used uninitialized in this
>function
>
>Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
>---
> kernel/async.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/kernel/async.c b/kernel/async.c
>index cd9dbb9..9c06931 100644
>--- a/kernel/async.c
>+++ b/kernel/async.c
>@@ -119,7 +119,7 @@ static void async_run_entry_fn(struct work_struct
>*work)
> 	struct async_entry *entry =
> 		container_of(work, struct async_entry, work);
> 	unsigned long flags;
>-	ktime_t calltime, delta, rettime;
>+	ktime_t calltime = {0}, delta, rettime;

I think this is a false positive so we can use uninitalized_var().

> 	/* 1) move self to the running queue */
> 	spin_lock_irqsave(&async_lock, flags);
>@@ -267,7 +267,7 @@ EXPORT_SYMBOL_GPL(async_synchronize_full_domain);
> void async_synchronize_cookie_domain(async_cookie_t cookie,
> 				     struct list_head *running)
> {
>-	ktime_t starttime, delta, endtime;
>+	ktime_t starttime = {0}, delta, endtime;
> 

Same for this one.

> 	if (initcall_debug && system_state == SYSTEM_BOOTING) {
> 		printk("async_waiting @ %i\n", task_pid_nr(current));

Thanks,

Jack


-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.

Re: [PATCH] kernel/async.c: fixing compilation warnings

[viresh kumar]

On 01/14/2011 02:48 PM, Jack Stone wrote:
> "Viresh Kumar" <viresh.kumar@st.com> wrote:
> 
>> This patch fixes following compilation warnings:
>> 270:10: warning: ‘starttime.tv64’ may be used uninitialized in this
>> function
>> 122:10: warning: ‘calltime.tv64’ may be used uninitialized in this
>> function
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
>> ---
>> kernel/async.c |    4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/async.c b/kernel/async.c
>> index cd9dbb9..9c06931 100644
>> --- a/kernel/async.c
>> +++ b/kernel/async.c
>> @@ -119,7 +119,7 @@ static void async_run_entry_fn(struct work_struct
>> *work)
>> 	struct async_entry *entry =
>> 		container_of(work, struct async_entry, work);
>> 	unsigned long flags;
>> -	ktime_t calltime, delta, rettime;
>> +	ktime_t calltime = {0}, delta, rettime;
> 
> I think this is a false positive so we can use uninitalized_var().
> 
>> 	/* 1) move self to the running queue */
>> 	spin_lock_irqsave(&async_lock, flags);
>> @@ -267,7 +267,7 @@ EXPORT_SYMBOL_GPL(async_synchronize_full_domain);
>> void async_synchronize_cookie_domain(async_cookie_t cookie,
>> 				     struct list_head *running)
>> {
>> -	ktime_t starttime, delta, endtime;
>> +	ktime_t starttime = {0}, delta, endtime;
>>
> 
> Same for this one.
> 

I will resend it with suggested changes.

--
viresh