Re: [PATCH] netfilter: nf_conntrack_tstamp: add flow-based timestamp extension

[Patrick McHardy <kaber@trash.net>]

On 14.01.2011 12:58, Pablo Neira Ayuso wrote:
>>> +static inline
>>> +struct nf_conn_tstamp *nf_ct_tstamp_ext_add(struct nf_conn *ct, gfp_t gfp)
>>> +{
>>> +	struct net *net = nf_ct_net(ct);
>>> +
>>> +	if (!net->ct.sysctl_tstamp)
>>> +		return NULL;
>>> +
>>> +	return nf_ct_ext_add(ct, NF_CT_EXT_TSTAMP, gfp);
>>
>> How about making this configurable at compile time to avoid any overhead
>> (memory in ct_extend and runtime) for anyone not needing it like most
>> of the other ct_extend options?
> 
> I'm fine with this, I'll add it.
> 
> Looking at the source, should we do the same with the accounting? I
> remember that we decided to remove this compile-time option time ago.

I see no reason why not.