All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jack Stone <jwjstone@fastmail.fm>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: linux-kernel@vger.kernel.org, arjan@linux.intel.com
Subject: Re: [PATCH resend] kernel/async.c: fixing compilation warnings
Date: Fri, 14 Jan 2011 13:13:10 +0000	[thread overview]
Message-ID: <4D304BE6.9070200@fastmail.fm> (raw)
In-Reply-To: <1295005980-12297-1-git-send-email-viresh.kumar@st.com>

[cc Arjan van de Ven]
On 14/01/2011 11:53, Viresh Kumar wrote:
> This patch fixes following compilation warnings:
> 270:10: warning: ‘starttime.tv64’ may be used uninitialized in this function
> 122:10: warning: ‘calltime.tv64’ may be used uninitialized in this function
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>

Looks good to me

Reviewed-by: Jack Stone <jwjstone@fastmail.fm>
> ---
>  kernel/async.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/async.c b/kernel/async.c
> index cd9dbb9..3ff777b 100644
> --- a/kernel/async.c
> +++ b/kernel/async.c
> @@ -119,7 +119,7 @@ static void async_run_entry_fn(struct work_struct *work)
>  	struct async_entry *entry =
>  		container_of(work, struct async_entry, work);
>  	unsigned long flags;
> -	ktime_t calltime, delta, rettime;
> +	ktime_t uninitialized_var(calltime), delta, rettime;
>  
>  	/* 1) move self to the running queue */
>  	spin_lock_irqsave(&async_lock, flags);
> @@ -267,7 +267,7 @@ EXPORT_SYMBOL_GPL(async_synchronize_full_domain);
>  void async_synchronize_cookie_domain(async_cookie_t cookie,
>  				     struct list_head *running)
>  {
> -	ktime_t starttime, delta, endtime;
> +	ktime_t uninitialized_var(starttime), delta, endtime;
>  
>  	if (initcall_debug && system_state == SYSTEM_BOOTING) {
>  		printk("async_waiting @ %i\n", task_pid_nr(current));


  reply	other threads:[~2011-01-14 13:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-14 11:53 [PATCH resend] kernel/async.c: fixing compilation warnings Viresh Kumar
2011-01-14 13:13 ` Jack Stone [this message]
2011-01-14 15:27   ` Arjan van de Ven
2011-01-14 18:39     ` Jack Stone
2011-01-14 19:13       ` Arjan van de Ven
2011-01-15 11:11         ` Jack Stone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D304BE6.9070200@fastmail.fm \
    --to=jwjstone@fastmail.fm \
    --cc=arjan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viresh.kumar@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.