All of lore.kernel.org
 help / color / mirror / Atom feed
From: seedshope <bocui107@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v3 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init
Date: Fri, 14 Jan 2011 23:51:03 +0800	[thread overview]
Message-ID: <4D3070E7.2040601@gmail.com> (raw)
In-Reply-To: <AANLkTinefYCV+zPZqF+cDKYwUPxhg=oJ2A6CkssrhTVE@mail.gmail.com>

On 01/14/2011 08:53 AM, Minkyu Kang wrote:
> Dear seedshope,
>
> On 13 January 2011 22:36, seedshope<bocui107@gmail.com>  wrote:
>> Since SDRAM init function have already change, So the SDRAM
>> initial function must be change.
>>
>> Signed-off-by: seedshope<bocui107@gmail.com>
>>
>> diff --git a/board/samsung/smdk6400/smdk6400.c b/board/samsung/smdk6400/smdk6400.c
>> index 35aa40b..043d553 100644
>> --- a/board/samsung/smdk6400/smdk6400.c
>> +++ b/board/samsung/smdk6400/smdk6400.c
>> @@ -78,10 +78,18 @@ int board_init(void)
>>         return 0;
>>   }
>>
>> -int dram_init(void)
>> +void dram_init_banksize(void)
>>   {
>> +       DECLARE_GLOBAL_DATA_PTR;
> Please move it to out of function.
I am sorry, DECLARE_GLOBAL_DATA_PTR have already defind  in the head of 
the file,
I will drop this declare.
>> +
>>         gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>>         gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
>> +}
>> +
>> +int dram_init(void)
>> +{
>> +       gd->ram_size = get_ram_size((long *)CONFIG_SYS_SDRAM_BASE, \
> Please remove "\".
>
ok

Thanks,
seedshope
>> +                       PHYS_SDRAM_1_SIZE);
>>
>>         return 0;
>>   }
>> --
>> 1.7.1
>>
>>
> Thanks
> Minkyu Kang

      reply	other threads:[~2011-01-14 15:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-13 13:36 [U-Boot] RR v3 PATCH: SMDK6400 Fix some build bug seedshope
2011-01-13 13:36 ` [U-Boot] [v3 patch 1/4] SMDK6400: Fix CONFIG_SYS_INIT_SP_ADDR undefined seedshope
2011-01-13 13:36 ` [U-Boot] [v3 patch 2/4] SMDK6400: Fix some label undefined in build error seedshope
2011-01-13 18:07   ` Albert ARIBAUD
2011-01-14 15:45     ` seedshope
2011-01-14 15:59       ` seedshope
2011-01-14 16:39       ` Albert ARIBAUD
2011-01-14 16:56         ` seedshope
2011-01-14 18:15           ` Albert ARIBAUD
2011-01-14 18:45             ` seedshope
2011-01-19 14:25             ` seedshope
2011-01-13 13:36 ` [U-Boot] [v3 patch 3/4] SMDK6400: Fix build error for nand_spl support seedshope
2011-01-13 13:36 ` [U-Boot] [v3 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init seedshope
2011-01-14  0:53   ` Minkyu Kang
2011-01-14 15:51     ` seedshope [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3070E7.2040601@gmail.com \
    --to=bocui107@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.